Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsdom should be a devDependency #117

Open
cscott opened this issue Sep 17, 2015 · 0 comments
Open

jsdom should be a devDependency #117

cscott opened this issue Sep 17, 2015 · 0 comments

Comments

@cscott
Copy link

cscott commented Sep 17, 2015

The package.json lists jsdom as an optional dependency. But the test suite for html5 uses jsdom. So the right thing would be to put jsdom in devDependencies as well as optionalDependencies.
@cscott cscott changed the title jsdom should be an optional dependency jsdom should be a devDependency Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cscott