Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All module slugs get reset on reorder. #2681

Open
Tom-revere opened this issue Oct 28, 2024 · 1 comment · May be fixed by #2688 or #2696
Open

All module slugs get reset on reorder. #2681

Tom-revere opened this issue Oct 28, 2024 · 1 comment · May be fixed by #2688 or #2696

Comments

@Tom-revere
Copy link

Description

When using self-nested module and reordering, the slugs for any nested pages get reset when one of the nested items gets reordered.

Steps to reproduce

  1. Setup a self-nested module as per the Twill docs.
  2. Enable re-ordering
  3. Have a parent page and 2+ nested pages, such as below
    image
  4. As per the above image, manually change one of the nested slugs to something different to default
  5. Change the order of the nested pages

Expected result

The order of these pages should update, but the slugs should stay the same

Actual result

The order is updated, but the slugs reset back to their default, as per here:
image

Versions

Twill: 3.4.1

Laravel: 11.29.0

PHP: 8.3.4

MySQL: 8.0.30
@Tom-revere
Copy link
Author

Just further info to this issue.

I had done some more testing today and it seems that any reordering at all will reset all slugs for that module, it is not just limited to the nested items or module that support nesting.

So take the following page order and slugs:
image

If we change up the order, all slugs are changed by to default:
image

@Tom-revere Tom-revere changed the title Slug for self-nested modules get reset on reorder. All module slugs get reset on reorder. Nov 1, 2024
@zeezo887 zeezo887 linked a pull request Nov 4, 2024 that will close this issue
Open
@Tofandel Tofandel linked a pull request Nov 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Tom-revere