Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide HashiCorp Vault secret provider #159

Closed
tomkerkhove opened this issue Jul 10, 2020 · 8 comments · Fixed by #183
Closed

Provide HashiCorp Vault secret provider #159

tomkerkhove opened this issue Jul 10, 2020 · 8 comments · Fixed by #183
Assignees
@stijnmoreels
Labels
feature All issues related to new features secret-provider All issues related to secret providers secret-store All issues related to our secret store
Milestone
v1.4.0

Comments

@tomkerkhove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Provide HashiCorp Vault secret provider
@tomkerkhove tomkerkhove added feature All issues related to new features secret-store All issues related to our secret store secret-provider All issues related to secret providers labels Jul 10, 2020
@stijnmoreels
Copy link
Member

An instance of HashiCorp can be created for this to test?

@tomkerkhove
Copy link
Contributor Author

Yes but you have to follow this approach: https://learn.hashicorp.com/vault/getting-started/install

Once we have the integration it will be important to check how it works with Kubernetes as they recommend using CSI or sidecar over there, but let's park that for now and integrate with the vault directly for now.

@stijnmoreels
Copy link
Member

Maybe we can build on top of this: https://github.com/rajanadar/VaultSharp

@tomkerkhove
Copy link
Contributor Author

Sounds good, I think having basic & Kubernetes auth are least minimum required

@stijnmoreels stijnmoreels self-assigned this Aug 13, 2020
@stijnmoreels
Copy link
Member

Sounds good, I think having basic & Kubernetes auth are least minimum required

Coming up!

@stijnmoreels
Copy link
Member

stijnmoreels commented Aug 19, 2020 •
edited
Loading

Update:

  • provider with UserPass and Kubernetes authentication.
  • Integration test for UserPass is done.
  • Integration test for Kubernetes.

@stijnmoreels stijnmoreels mentioned this issue Aug 20, 2020
Merged
@stijnmoreels
Copy link
Member

Closing in favor of #173 .

@stijnmoreels stijnmoreels mentioned this issue Sep 8, 2020
Closed
@tomkerkhove tomkerkhove added this to the v1.4.0 milestone Sep 10, 2020
@tomkerkhove
Copy link
Contributor Author

Can we add a link to this new secret provider on https://security.arcus-azure.net/preview/ please?

@tomkerkhove tomkerkhove reopened this Sep 10, 2020
@stijnmoreels stijnmoreels mentioned this issue Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
feature All issues related to new features secret-provider All issues related to secret providers secret-store All issues related to our secret store
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Docs - add HashiCorp Vault link to index page
2 participants
@tomkerkhove @stijnmoreels