Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typings comparing to the original SDK version #61

Open
just-boris opened this issue Dec 25, 2023 · 1 comment
Open

Improve typings comparing to the original SDK version #61

just-boris opened this issue Dec 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@just-boris
Copy link

Describe the problem underlying the enhancement request

There is a known issue on AWS SDK v3 typings: aws/aws-sdk-js-v3#1613

Marking everything as possibly undefined undermines the whole point of typings in the first place.

Since this package tries to reuse the upstream type definitions, it is suffering from the same issue too.

Describe the solution you'd like (if any)

The aws-lite project could provide enhanced typings for the most common use-cases

Describe alternative solutions you've considered

For now I am just using non-null assertion ! everywhere

Additional context or notes

This is not much of a feature request, more like a suggestion for to take an opportunity

@just-boris just-boris added the enhancement New feature or request label Dec 25, 2023
@ryanblock
Copy link
Member

Thank you – I don't really use types, so this is pretty interesting to learn. Unfortunately, I'm not super surprised.

For aws-lite, I decided to add @aws-lite/*-types package support as an easy(ish) win to ease the transition from SDK v3 and help folks get comprehensive types without being a huge burden on us during the early days of this project. AWS has (or had?) dozens of developers working on the JS SDK; right now aws-lite has, um, me and @tbeseda! 😅

As such, I think attempting to maintain our own types is currently out of scope. However, as the project grows I could see this as being something we take on eventually, especially if AWS teams and outside contributors begin to help us maintain them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants