Async iterator pagination #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
Extra notes:
|
Enable iterative pagination in raw client Improve iterator error handling
aspilchen
commented
Jul 3, 2024
There was a problem hiding this comment.
Line 268 in bebf88c
Throws error if params[type] does not exist
ryanblock
requested changes
Jul 4, 2024
| request = server.getCurrentRequest() | ||
| expectedUrl = '/?Cursor=t1' | ||
| t.deepEqual(page.value.payload, simpleResponseBodies[1], 'Incorrect response body') | ||
| t.equal(request.url, expectedUrl, 'Response token does not match next request cursor') |
There was a problem hiding this comment.
All of these tests notate "incorrect..." or "does not match..." when a passing test would be correct, or match, etc. As a reminder, the third argument in most of these tape methods is the description of the test in question.
|
|
||
| // Query type, no more pages | ||
| page = await response.next() | ||
| t.true(page.done, 'Iterator not done when it ought to be') |
Got it, interesting this hasn't come up, but that's why unit tests are nice. :) I'm thinking if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping out! ✨
We really appreciate your commitment to improving Architect
To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:
masternpm itfrom the repo root)readme.md, help docs, inline docs & comments, etc.)changelog.mdPlease also be sure to completed the CLA (if you haven't already).
Learn more about contributing to Architect here.
Thanks again!