Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve aeSwap integration #936

Merged
merged 16 commits into from
Jul 22, 2024
Merged

Improve aeSwap integration #936

merged 16 commits into from
Jul 22, 2024

Conversation

redDwarf03
Copy link
Member

@redDwarf03 redDwarf03 commented Apr 18, 2024 •
edited
Loading

  • Improve aeSwap integration
  • Move messaging to DApps list tab

@redDwarf03 redDwarf03 linked an issue Apr 18, 2024 that may be closed by this pull request
Improve aeSwap integration #935
Closed
@redDwarf03 redDwarf03 marked this pull request as draft May 20, 2024 13:14
@redDwarf03 redDwarf03 requested a review from Chralu May 20, 2024 17:36
@redDwarf03
Copy link
Member Author

redDwarf03 commented May 20, 2024 •
edited
Loading

@Chralu TODO

  • Take into account inactivity time constraints
  • Cache retention issue (Base Hive) to be addressed
  • Mainnet pool list display crashes
  • Certificate management
  • Issue with network loss
  • keyboard needs dot

@redDwarf03 redDwarf03 force-pushed the 935-improve-aeswap-integration branch from 7749060 to 2cbd854 Compare May 20, 2024 17:38
@redDwarf03
Copy link
Member Author

rebase fait

@redDwarf03 redDwarf03 force-pushed the 935-improve-aeswap-integration branch from 2cbd854 to 66a944e Compare May 20, 2024 20:01
@Chralu Chralu force-pushed the 935-improve-aeswap-integration branch from 9c15d0f to eb34394 Compare May 21, 2024 09:53
@redDwarf03 redDwarf03 force-pushed the 935-improve-aeswap-integration branch 2 times, most recently from 420f8b0 to ffdb4b5 Compare June 4, 2024 18:19
@redDwarf03 redDwarf03 mentioned this pull request Jun 23, 2024
Merged
@redDwarf03 redDwarf03 mentioned this pull request Jul 17, 2024
Merged
@redDwarf03 redDwarf03 force-pushed the 935-improve-aeswap-integration branch from d97b890 to 2f1ccf9 Compare July 17, 2024 07:28
@redDwarf03 redDwarf03 added this to the 2.3.8 milestone Jul 17, 2024
@Chralu Chralu mentioned this pull request Jul 17, 2024
Closed
@redDwarf03 redDwarf03 force-pushed the 935-improve-aeswap-integration branch from 169f8fb to 4872112 Compare July 21, 2024 07:58
@redDwarf03 redDwarf03 force-pushed the 935-improve-aeswap-integration branch from 4872112 to 4982694 Compare July 22, 2024 07:45
@Chralu Chralu mentioned this pull request Jul 22, 2024
Merged
Chralu
Chralu reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@Chralu Chralu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redDwarf03 necessite archethic-wallet-client-dart de la PR suivante : archethic-foundation/archethic-wallet-client-dart#48

Chralu
Chralu reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@Chralu Chralu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redDwarf03 je recontre le bug suivant sur Android API 28 :

pichillilorenzo/flutter_inappwebview#2150

@Chralu Chralu marked this pull request as ready for review July 22, 2024 12:43
redDwarf03
redDwarf03 commented Jul 22, 2024
View reviewed changes
lib/infrastructure/repositories/dapps_repository.dart Outdated
@@ -46,6 +46,12 @@ class DAppsRepositoryImpl implements DAppsRepositoryInterface {
Future<List<DApp>> getDAppsFromNetwork(
AvailableNetworks network,
) async {
return [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a trap lol

@redDwarf03 redDwarf03 mentioned this pull request Jul 22, 2024
Closed
@redDwarf03
Copy link
Member Author

redDwarf03 commented Jul 22, 2024 •
edited
Loading

tests ok with iOS (iphone & ipad)
ko with android
Issues created with AWCWebview label
The wallet code is ok but depends of flutterinappwebview lib

@redDwarf03 redDwarf03 merged commit 44d8945 into dev Jul 22, 2024
3 checks passed
@redDwarf03 redDwarf03 deleted the 935-improve-aeswap-integration branch July 22, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chralu Chralu Chralu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.8
Development

Successfully merging this pull request may close these issues.

Improve aeSwap integration
2 participants
@redDwarf03 @Chralu