Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox, Radio: avoid toggling on 'enter' #626

Closed
sohkai opened this issue Oct 17, 2019 · 1 comment · Fixed by #817
Closed

Checkbox, Radio: avoid toggling on 'enter' #626

sohkai opened this issue Oct 17, 2019 · 1 comment · Fixed by #817
Assignees
@eliobricenov
Labels
bug

Comments

@sohkai
Copy link
Contributor

sohkai commented Oct 17, 2019

From https://github.com/aragon/aragon-ui/pull/620#discussion_r335479434:

the behavior of Checkbox is wrong: the enter key should be used to submit forms (if any) when a checkbox is focused, not to toggle the checkbox itself (reference).
@sohkai sohkai added the bug label Oct 17, 2019
@sohkai sohkai mentioned this issue Oct 17, 2019
Merged
@stale stale bot added the abandoned label Apr 14, 2020
@aragon aragon deleted a comment from stale bot Apr 14, 2020
@stale stale bot removed the abandoned label Apr 14, 2020
@bpierre bpierre pinned this issue May 18, 2020
@eliobricenov eliobricenov self-assigned this Feb 11, 2021
@eliobricenov
Copy link
Contributor

I can work on this.

@eliobricenov eliobricenov mentioned this issue Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliobricenov eliobricenov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checkbox [fix]: prevent default onkeypress action aragon/ui
2 participants
@sohkai @eliobricenov