You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Goal
For this type of screens (results not found or empty states) make the box take the 75% of the screen height in a way that we ensure it won't collide with the Help scout button.
Considerations
Apps should be aware if the Help Scout button is being displayed (this is not implemented).
Concerns
These changes will need quite a handful of changes on a lot of components that are used all around - potentially impact other layouts:
Changes to Main: flex-direction: column; display: flex; (red container in screenshot)
Changes to Layout: flex: 1; and compact onlywidth: 100%; (yellow container in screenshot)
Voting (will have to do this per app per container)
Changes to containing element height: calc(75vh - 168px); min-height: 450px;
Considerations
New height of 75% of the available space (considering the 168px used up by the app title, filters and margin, see attached screenshot).
I suggest we have this span 75% of the available space up to a certain point (min-height) so that the box does not collapse beyond its own content. So at that point the Help Scout button will show on top of the card.
Is it worth the effort for such a small visual change?
Should we consider using another percentage? If we go back to the idea of spanning up to the help scout button then that would require more changes.
Required specs if we proceed
Small viewports, and this not only refers to mobile but also desktop browsers that have been vertically resized.
I'm open to suggestions and ideas.
The text was updated successfully, but these errors were encountered:
References
Goal
For this type of screens (results not found or empty states) make the box take the 75% of the screen height in a way that we ensure it won't collide with the Help scout button.
Considerations
Apps should be aware if the Help Scout button is being displayed (this is not implemented).
Concerns
These changes will need quite a handful of changes on a lot of components that are used all around - potentially impact other layouts:
Changes to
Main
:flex-direction: column; display: flex;
(red container in screenshot)Changes to
Layout
:flex: 1;
andcompact only
width: 100%;
(yellow container in screenshot)Voting (will have to do this per app per container)
Changes to containing element
height: calc(75vh - 168px); min-height: 450px;
Considerations
New height of 75% of the available space (considering the 168px used up by the app title, filters and margin, see attached screenshot).
I suggest we have this span 75% of the available space up to a certain point (
min-height
) so that the box does not collapse beyond its own content. So at that point the Help Scout button will show on top of the card.How will this look like
168px calculations
Videos
cc @bpierre so that he can chip in with insights on how these changes will impact other places where this components are being used.
👆 Those changes make it so that these containers use up 75% of their available space which is NOT that different from the current behaviour:
Is it worth the effort for such a small visual change?
Should we consider using another percentage? If we go back to the idea of spanning up to the help scout button then that would require more changes.
Required specs if we proceed
Small viewports, and this not only refers to mobile but also desktop browsers that have been vertically resized.
I'm open to suggestions and ideas.
The text was updated successfully, but these errors were encountered: