Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting: no results and EmptyStateCards vertical span #1004

Closed
AquiGorka opened this issue Sep 19, 2019 · 1 comment
Closed

Voting: no results and EmptyStateCards vertical span #1004

AquiGorka opened this issue Sep 19, 2019 · 1 comment
Assignees

Comments

@AquiGorka
Copy link
Contributor

AquiGorka commented Sep 19, 2019

References

Goal
For this type of screens (results not found or empty states) make the box take the 75% of the screen height in a way that we ensure it won't collide with the Help scout button.

Considerations
Apps should be aware if the Help Scout button is being displayed (this is not implemented).

Concerns
These changes will need quite a handful of changes on a lot of components that are used all around - potentially impact other layouts:

Changes to Main: flex-direction: column; display: flex; (red container in screenshot)
Changes to Layout: flex: 1; and compact only width: 100%; (yellow container in screenshot)

Voting (will have to do this per app per container)
Changes to containing element height: calc(75vh - 168px); min-height: 450px;

Considerations
New height of 75% of the available space (considering the 168px used up by the app title, filters and margin, see attached screenshot).

I suggest we have this span 75% of the available space up to a certain point (min-height) so that the box does not collapse beyond its own content. So at that point the Help Scout button will show on top of the card.

How will this look like
image

168px calculations
image

Videos

cc @bpierre so that he can chip in with insights on how these changes will impact other places where this components are being used.

👆 Those changes make it so that these containers use up 75% of their available space which is NOT that different from the current behaviour:

Is it worth the effort for such a small visual change?
Should we consider using another percentage? If we go back to the idea of spanning up to the help scout button then that would require more changes.

Required specs if we proceed
Small viewports, and this not only refers to mobile but also desktop browsers that have been vertically resized.

I'm open to suggestions and ideas.

@AquiGorka AquiGorka assigned sohkai and unassigned luisivan Oct 8, 2019
@sohkai sohkai changed the title No results and EmptyStateCards vertical span Voting: no results and EmptyStateCards vertical span Oct 16, 2019
@sohkai
Copy link
Contributor

sohkai commented Mar 18, 2020

Closing; generally the HelpScout button being overlayed on top has not been problematic with the current design.

@sohkai sohkai closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants