Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remve attribute ogit:_tags from ogit:optional-attributes #458

Open
vteremasov opened this issue May 16, 2019 · 2 comments
Open

Remve attribute ogit:_tags from ogit:optional-attributes #458

vteremasov opened this issue May 16, 2019 · 2 comments

Comments

@vteremasov
Copy link
Contributor

What
Remove ogit:_tags described in optional attributes Variable.ttl

ogit:optional-attributes (
ogit:_tags
);

Why

  1. We don't need to describe fields such as ogit:_tags or ogit:_content explicitly.
  2. It confuses some hiro-graph client libraries
@KaushikGondaliya
Copy link
Contributor

The optional attribute 'ogit:_tags' was added to defines tags for each variable. So information such which variable belongs to which namespace can be gathered.

for ex. 'allowedTypes' has tag 'Auth' then it will be mostly used in Auth namespace.

So what kind of problems it is creating that it needs to be removed?

@vteremasov
Copy link
Contributor Author

vteremasov commented May 16, 2019

@KaushikGondaliya

I think you don't need to to add this attribute to use it. Same with ogit:_content or ogit:_id. @viteke please correct me if I am wrong.

We have a client library that shows this as an invalid scheme. Anyway, I think we could add a fallback for such cases, but I thought it was added by mistake and created an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants