Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Feature Extractors #3

Open
joaogui1 opened this issue Oct 22, 2022 · 5 comments · May be fixed by #4
Open

Adding Feature Extractors #3

joaogui1 opened this issue Oct 22, 2022 · 5 comments · May be fixed by #4
Labels
enhancement New feature or request

Comments

@joaogui1
Copy link

I think adding the feature extractors from SB3 is a good next step towards feature parity between the libraries
@araffin araffin added the enhancement New feature or request label Oct 22, 2022
@araffin
Copy link
Owner

araffin commented Oct 22, 2022

Hello,
thanks for the proposal, achieving full feature parity is not my priority for now (as SBX is meant to be experimental) but I would welcome such PR =)

@araffin araffin linked a pull request Oct 22, 2022 that will close this issue
Draft
14 tasks
@araffin
Copy link
Owner

araffin commented Jul 11, 2024

Small update, I added CNN support for DQN: #49

I don't think separating fully features extractor and actor net would make sense for SBX.

Repository owner deleted a comment Jul 29, 2024
@yhs0602
Copy link

yhs0602 commented Jan 13, 2025 •
edited
Loading

Hello, is supporting CnnPolicy for PPO planned or actively ongoing? Or should I create a Pull Request?

@araffin
Copy link
Owner

araffin commented Jan 13, 2025

Hello,

Or should I create a Pull Request?

Please open a PR =)
This should be similar to #49

@yhs0602
Copy link

yhs0602 commented Jan 14, 2025

Thank you for the quick response! Got it, I’ll work on opening a PR when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements Feature Extractors joaogui1/sbx
3 participants
@araffin @joaogui1 @yhs0602