Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing log_dir in PlottingCallback #14

Open
dariomangoni opened this issue May 6, 2022 · 1 comment
Open

Missing log_dir in PlottingCallback #14

dariomangoni opened this issue May 6, 2022 · 1 comment

Comments

@dariomangoni
Copy link

In 4_callbacks_hyperparameter_tuning.ipynb I see that PlottingCallback has no log_dir nor self.log_dir variables available, but yet it is called in x, y = ts2xy(load_results(log_dir), 'timesteps')

Did I miss something? It's just a tiny detail...

BTW, thanks for the great job. These tutorial are really helpful and the stable baseline docs are just great!

@araffin
Copy link
Owner

araffin commented May 6, 2022

Hello,
you are right, the callback is actually accessing a global variable defined earlier, it would be cleaner to have it as argument.
and thanks for the kind words =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants