Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve app addresses from DAO name in dao.json #29

Open
yeqbfgxjiq opened this issue Apr 18, 2020 · 4 comments
Open

Resolve app addresses from DAO name in dao.json #29

yeqbfgxjiq opened this issue Apr 18, 2020 · 4 comments

Comments

@yeqbfgxjiq
Copy link
Contributor

Moved over from aracred/onboarding#5

Right now the person who sets up AraCred needs to manually input daoAddress, tokenManagerAddress and votingAddress.

It'd be way easier if they could just input the ENS name of the DAO (we can label it as daoName).

@yeqbfgxjiq
Copy link
Contributor Author

@Evalir how easy/hard is this to setup?

@pythonpete32
Copy link
Member

The problem with this is it assumes the DAO will have only one token manager or voting app which is not always the case

@Evalir
Copy link
Contributor

Evalir commented Apr 19, 2020

Yes; as Aaron says, there are a few UX concerns to this:

  • We cannot assume a user will only have one token manager or voting app instance; we can filter out only these instances and let the user choose which one he wants to activate, but this makes the CLI questionnaire quite long. Also, if he has a different "voting" app, such a custom voting app or dot voting, I'm not sure Aracred will work correctly.
  • We will need to add @aragon/wrapper for this, and, this package is quite heavy and extensive; this makes the CLI heavier, and so it makes the download time increase. I don't think this is desired, as downloading packages from NPM is already quite slow.

We may be able to implement this smoothly once the toolkit's ready, but there's no good timeframe for these features to be ready other than Q2 2020.

@pythonpete32
Copy link
Member

plumbery (toolkit) is going to be released this week, what priority It would be nice to refactor the whole codebase using plumber. we can overcome a lot of the pain setting up Aracred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants