Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suse): added SUSE Linux Enterprise Micro support #7294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(suse): added SUSE Linux Enterprise Micro support #7294

wants to merge 1 commit into from

Conversation

msmeissn
Copy link
Contributor

@msmeissn msmeissn commented Aug 1, 2024 •
edited
Loading

This adds support for the SUSE Linux Enterprise Micro family.

#7221

Description

Related issues

Related PRs

Checklist

  • [x ] I've read the guidelines for contributing to this repository.
  • [ x] I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • [- ] I've added usage information (if the PR introduces new options)
  • [-] I've included a "before" and "after" example to the description (if the PR is a user interface change).

DmitriyLewen
DmitriyLewen reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @msmeissn
Thanks for your work!

i left a comments.
also:

  • bump trivy-db version
  • update PR title scope (feat(suse): ...)
  • update purl package
    • perhaps we need to use short name (as for SLES) in distro qualifier
    • add micro in purlType() function

pkg/fanal/analyzer/os/release/release.go Show resolved Hide resolved
@msmeissn msmeissn changed the title feat(slemicro): added SUSE Linux Enterprise Micro support feat(suse): added SUSE Linux Enterprise Micro support Aug 15, 2024
@msmeissn
Copy link
Contributor Author

(i am on vacation currently, so a bit delayed progress)

@knqyf263
Copy link
Collaborator

So we are. Take your time.
#7303

@msmeissn
feat(suse): added SUSE Linux Enterprise Micro support
5ae1927 
This adds support for the SUSE Linux Enterprise Micro family.

This also fixes also purl logic for SUSE and openSUSE to match standard
expectations better.

aquasecurity#7221

Signed-off-by: Marcus Meissner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen left review comments

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(slemicro): Add support for the SUSE Linux Enterprise Micro family
3 participants
@msmeissn @knqyf263 @DmitriyLewen