Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(golang): support toolchain directive #7111

Closed
knqyf263 opened this issue Jul 8, 2024 · 0 comments · Fixed by #7163
Closed

feat(golang): support toolchain directive #7111

knqyf263 opened this issue Jul 8, 2024 · 0 comments · Fixed by #7163
Assignees
@DmitriyLewen
Milestone
v0.55.0

Comments

@knqyf263
Copy link
Collaborator

knqyf263 commented Jul 8, 2024 •
edited
Loading

Description

Currently, when scanning Go binaries, the stdlib version is identified from the go version -m result, but not when scanning go.mod. With the introduction of Go Toolchains, the version of Go used in a project can now be strictly specified, so we should use this version as stdlib.

module github.com/aquasecurity/trivy

go 1.22.0

toolchain go1.22.4

In this example, we take 1.22.4 as the stdlib version.
@knqyf263 knqyf263 added this to the v0.54.0 milestone Jul 8, 2024
@DmitriyLewen DmitriyLewen mentioned this issue Jul 15, 2024
Merged
6 tasks
@knqyf263 knqyf263 removed this from the v0.54.0 milestone Jul 23, 2024
@knqyf263 knqyf263 added this to the v0.55.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
Trivy Roadmap
Archived in project
Milestone
v0.55.0
Development

Successfully merging a pull request may close this issue.

feat(go): use toolchain as stdlib version for go.mod files DmitriyLewen/trivy
2 participants
@knqyf263 @DmitriyLewen