-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misconf): Improve scan results messaging #6138
Comments
@simar7 Should we only change the wording of the |
@nikpivkin as you brought up here this result contains passed items as well. I looked into adding more logic to decouple that but didn't finish the implementation. Ideally if we can show the user how many "relevant" files were scanned by the IaC scanner, it would be more relevant. In this case a "relevant" file would be the one that we've processed through the scanner. Currently we don't keep track of this AFAIK. |
I've created #7473 as I think it is sufficient to show the count of files scanned and the count of "relevant" config files found that were scanned. Besides this, I'm not sure what much we can do in this case to improve it. |
@simar7 Is there a need to report how many total files were scanned? We can report the number of files with misconfigurations. |
I think we're good for now. |
When reporting misconfiguration scanning results we can be more descriptive about how many "total" files were scanned and how many "misconfigured" files were found.
See context below for details:
Trivy successfully scans the ARM template. I think the message
Detected config files: 0
might be misleading.@simar7 The issue is that the Azure state for the scan was empty and no checks were applied to it, so Trivy reported that 0 configs were detected.
Originally posted by @nikpivkin in #6123 (comment)
The text was updated successfully, but these errors were encountered: