Skip to content

Commit 5a1333e

Browse files
committed
Fix close button to be semantic html
1 parent d88cfbb commit 5a1333e

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

src/toastify-es.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -238,10 +238,11 @@ class Toastify {
238238
// Adding a close icon to the toast
239239
if (this.options.close === true) {
240240
// Create a span for close element
241-
let closeElement = document.createElement("span");
242-
closeElement.innerHTML = "✖";
243-
241+
let closeElement = document.createElement("button");
242+
closeElement.type = "button";
243+
closeElement.setAttribute("aria-label", "Close");
244244
closeElement.className = "toast-close";
245+
closeElement.innerHTML = "✖";
245246

246247
// Triggering the removal of toast from DOM on close click
247248
closeElement.addEventListener(

src/toastify.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@
2828
}
2929

3030
.toast-close {
31+
background: transparent;
32+
border: 0;
33+
color: white;
34+
cursor: pointer;
35+
font-family: inherit;
36+
font-size: 1em;
3137
opacity: 0.4;
3238
padding: 0 5px;
3339
}

src/toastify.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,11 @@
160160
// Adding a close icon to the toast
161161
if (this.options.close === true) {
162162
// Create a span for close element
163-
var closeElement = document.createElement("span");
164-
closeElement.innerHTML = "✖";
165-
163+
var closeElement = document.createElement("button");
164+
closeElement.type = "button";
165+
closeElement.setAttribute("aria-label", "Close");
166166
closeElement.className = "toast-close";
167+
closeElement.innerHTML = "✖";
167168

168169
// Triggering the removal of toast from DOM on close click
169170
closeElement.addEventListener(

0 commit comments

Comments
 (0)