Merge pull request #256 from appwrite/fix-php-null-check

TorstenDittmann · web-flow · commit b89a51170f99 · 2021-09-07T15:23:19.000+02:00
fix(php): null/false check
diff --git a/templates/php/src/Services/Service.php.twig b/templates/php/src/Services/Service.php.twig
@@ -28,7 +28,7 @@ class {{ service.name | caseUcfirst }} extends Service
     {
 {% for parameter in method.parameters.all %}
 {% if parameter.required %}
-        if (empty(${{ parameter.name | caseCamel | escapeKeyword }})) {
+        if (!isset(${{ parameter.name | caseCamel | escapeKeyword }})) {
             throw new {{spec.title | caseUcfirst}}Exception('Missing required parameter: "{{ parameter.name | caseCamel | escapeKeyword }}"');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class {{ service.name \| caseUcfirst }} extends Service`
`28`	`28`	`{`
`29`	`29`	`{% for parameter in method.parameters.all %}`
`30`	`30`	`{% if parameter.required %}`
`31`		`- if (empty(${{ parameter.name \| caseCamel \| escapeKeyword }})) {`
	`31`	`+ if (!isset(${{ parameter.name \| caseCamel \| escapeKeyword }})) {`
`32`	`32`	`throw new {{spec.title \| caseUcfirst}}Exception('Missing required parameter: "{{ parameter.name \| caseCamel \| escapeKeyword }}"');`
`33`	`33`	`}`
`34`	`34`