Skip to content

Commit 1793377

Browse files
committed
feat: review comments
1 parent 2b82efa commit 1793377

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

templates/cli/README.md.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ $ {{ language.params.executableName }} database createDocument --collectionId="Y
8282

8383
### Some Gotchas
8484
- `data` expects the JSON string to be escaped.
85-
- If using the wildcard (`*`) read or write permissions , make sure that it is properly escaped using a `\` or by enclosing it in `"*"`.
86-
- Some arguments like `read` and `write` permissions are expected to be arrays. In the {{ spec.title }} CLI arrays are passed by simply repeating the argument as seen in the `createDocument` example above.
85+
- If using the wildcard (`*`) read or write permissions , make sure that it is properly escaped using a `\` or by enclosing it in `"*"` since bash interprets them differently.
86+
- Some arguments like `read` and `write` permissions are expected to be arrays. In the {{ spec.title }} CLI, arrays are passed by simply repeating the argument as seen in the `createDocument` example above.
8787

8888
To get information about the different services available, you can use
8989
```sh

tests/SDKTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,7 @@ public function testHTTPSuccess()
200200
throw new \Exception('Failed to fetch spec from Appwrite server');
201201
}
202202

203-
// $whitelist = ['php', 'cli', 'node', 'ruby', 'python', 'typescript', 'deno', 'dotnet', 'dart', 'flutter'];
204-
$whitelist = ['cli'];
203+
$whitelist = ['php', 'cli', 'node', 'ruby', 'python', 'typescript', 'deno', 'dotnet', 'dart', 'flutter'];
205204

206205
foreach ($this->languages as $language => $options) {
207206
if (!empty($whitelist) && !in_array($language, $whitelist)) {

0 commit comments

Comments
 (0)