🐛 Bug Report: Inconsistency in User Verification Status between Email and Phone Number

[gurjeetsinghvirdee]

👟 Reproduction steps

• To trigger this bug, begin by accessing the Auth,
• Create a new user account and navigate to the user profile to verify the account.
• Start the verification process for both the email address and the phone number associated with the user account. Initially, verify the email address, which should proceed smoothly.
• Next, attempt to verify the phone number, Despite the successful verification of the email address, the system incorrectly indicates that the user is unverified when verifying the phone number.
• In an attempt to rectify this inconsistency, proceed to unverify the phone number. Unexpectedly, the system now displays an alert indicating that the user is verified, contradicting the initial indication of being unverified.

👍 Expected behavior

• When the user hits Verify Phone, the alert should confirm that the user is verified.
• When the user hits Unverify Phone, the alert should confirm that the user is unverified.

👎 Actual Behavior

When attempting to verify the phone number, an alert incorrectly states that the user is unverified.
However, when attempting to unverify the phone, the system incorrectly indicates that the user is verified.

🎲 Appwrite version

Version 1.4.x

💻 Operating system

Windows

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[gurjeetsinghvirdee]

bug.mp4

[ItzNotABug]

Reproducible on 1.5.4 too.

[stnguyen90]

@gurjeetsinghvirdee, thanks for raising this issue! 🙏🏼 Let me confirm with the team.

[stnguyen90]

We want to update the alerts to be specific to say:

XYZ's email has been verified
XYZ's email has been unverified
XYZ's phone has been verified
XYZ's phone has been unverified

Note

The "s" should only be there if the name does not end with s. For example, if the user's name was "Charles", it should be "Charles' email has been verified"

FYI, the code that needs to be updated is here:

console/src/routes/(console)/project-[project]/auth/user-[user]/updateStatus.svelte

Lines 15 to 54 in 6748b14

	async function updateVerificationEmail() {
	showVerifcationDropdown = false;
	try {
	await sdk.forProject.users.updateEmailVerification($user.$id, !$user.emailVerification);
	await invalidate(Dependencies.USER);
	addNotification({
	message: `${$user.name || $user.email || $user.phone || 'The account'} has been ${
	!$user.emailVerification ? 'unverified' : 'verified'
	}`,
	type: 'success'
	});
	trackEvent(Submit.UserUpdateVerificationEmail);
	} catch (error) {
	addNotification({
	message: error.message,
	type: 'error'
	});
	trackError(error, Submit.UserUpdateVerificationEmail);
	}
	}
	async function updateVerificationPhone() {
	showVerifcationDropdown = false;
	try {
	await sdk.forProject.users.updatePhoneVerification($user.$id, !$user.phoneVerification);
	await invalidate(Dependencies.USER);
	addNotification({
	message: `${$user.name || $user.email || $user.phone || 'The account'} has been ${
	$user.phoneVerification ? 'unverified' : 'verified'
	}`,
	type: 'success'
	});
	trackEvent(Submit.UserUpdateVerificationPhone);
	} catch (error) {
	addNotification({
	message: error.message,
	type: 'error'
	});
	trackError(error, Submit.UserUpdateVerificationPhone);
	}
	}

[pushkar707]

Hi, assuming that the previous PR has some issues since it hasn't been merged so far. Can I take over this issue?

[gurjeetsinghvirdee]

@pushkar707
Since it doesn't merge that doesn't mean the PR have issues, PRs been merged according to the priority level!