Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Implement pull-based auto-upgrade of module instances in an application #36523

Open
subrata71 opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels
Backend This marks the issue or pull request to reference server code Packages Pod issues that belong to the packages pod Task A simple Todo

Comments

@subrata71
Copy link
Contributor

subrata71 commented Sep 24, 2024

SubTasks

  • Create a new API to trigger the pull-based auto-upgrade for the current branch (git-connected) or the current application (non-git-connected app)
  • Build a mechanism to pull changes for the selected version

API to pull changes for a specific version

Request:
PUT /api/v1/packages/{packageId}/pull
Body:

{
   "baseApplicationId": "",
   "version": ""
}

Response:

{
  "responseMeta": {
    "status": 200,
    "success": true
  },
  "data": true,
  "errorDisplay": ""
}
@subrata71 subrata71 added Backend This marks the issue or pull request to reference server code Task A simple Todo Packages Pod issues that belong to the packages pod labels Sep 24, 2024
@subrata71 subrata71 self-assigned this Sep 24, 2024
@ashit-rath
Copy link
Contributor

@subrata71

  1. Why is it a PUT rather than a POST?
  2. Can this API return the module instances, instance entities, and updated consumable modules?

@subrata71
Copy link
Contributor Author

subrata71 commented Sep 27, 2024

@ashit-rath It's PUT because it actullay updates the existing module instances but I am okay to change it to POST.
I thought after the pull succeeds the front-end will reload the page that ensures getting what you asked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This marks the issue or pull request to reference server code Packages Pod issues that belong to the packages pod Task A simple Todo
Projects
None yet
Development

No branches or pull requests

2 participants