Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Run button not disabled in response pane #36496

Open
1 task done
albinAppsmith opened this issue Sep 24, 2024 · 5 comments
Open
1 task done

[Bug]: Run button not disabled in response pane #36496

albinAppsmith opened this issue Sep 24, 2024 · 5 comments
Assignees
@Jai-Marothiya
Labels
Bug Something isn't working Integrations Product Issues related to a specific integration Inviting Contribution Issues that we would like contributions to Low An issue that is neither critical nor breaks a user flow Postgres Postgres related issues Production Query & JS Pod Issues related to the query & JS Pod

Comments

@albinAppsmith
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Description

When there is no query is added in the query input box, run button on top query page is getting disabled. But the same behaviour is not maintained for the run button in response pane.

Steps To Reproduce

  1. Goto and postgres query
  2. Delete the content inside query input
  3. Observe run button in response pane

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

Appsmith v1.42.0-SNAPSHOT
@albinAppsmith albinAppsmith added Bug Something isn't working Postgres Postgres related issues labels Sep 24, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow Production labels Sep 24, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod labels Sep 24, 2024
@Jai-Marothiya
Copy link

Hello @albinAppsmith - I believe, I can fix this issue. Please assign it to me.

@rohan-arthur rohan-arthur added the Inviting Contribution Issues that we would like contributions to label Oct 3, 2024
@rohan-arthur
Copy link
Contributor

@Jai-Marothiya thank you, and go for it! :)

@PrasadMadine
Copy link
Contributor

PrasadMadine commented Oct 3, 2024 •
edited
Loading

Hello @rohan-arthur @albinAppsmith , the issue does not lies only in postgress, but also in rest API even in GraphQL

image (10)

In GraphQL, when there is no endpoint specified in the input, the run button is not being disabled in both places as it is disabled for RestAPI.

image (11)

@Jai-Marothiya
Copy link

@rohan-arthur - I tried to set up project but there is some issue in my system due to which I am not able to set up project. I'll try it again after some time.

@PrasadMadine
Copy link
Contributor

@rohan-arthur , Can I go a head with this issue.

@PrasadMadine PrasadMadine mentioned this issue Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jai-Marothiya Jai-Marothiya

Labels
Bug Something isn't working Integrations Product Issues related to a specific integration Inviting Contribution Issues that we would like contributions to Low An issue that is neither critical nor breaks a user flow Postgres Postgres related issues Production Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Nikhil-Nandagopal @albinAppsmith @rohan-arthur @Jai-Marothiya @PrasadMadine