Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter when a user uses {{appsmith.xyz}} binding in workflow code and JS library usage #36431

Open
infinitetrooper opened this issue Sep 19, 2024 · 0 comments
Open

Add linter when a user uses {{appsmith.xyz}} binding in workflow code and JS library usage #36431

infinitetrooper opened this issue Sep 19, 2024 · 0 comments
Assignees
@ayushpahwa
Labels
Enhancement New feature or request Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product

Comments

@infinitetrooper
Copy link
Contributor

infinitetrooper commented Sep 19, 2024 •
edited by nsarupr
Loading

{{appsmith.xyz}} bindings only work for logged-in users, since workflow doesn't have a user associated. We should throw error lint warnings if these bindings are used as they will be undefined.

Remove the following from workflows

  • appsmith.user
  • appsmith.geolocation
  • appsmith.theme
  • appsmith.URL
  • appsmith.mode
  • appsmith.store

Show linter errors on JS Library usage as well.
@infinitetrooper infinitetrooper added Enhancement New feature or request Workflows Workflows Pod Issues that the workflows team owns labels Sep 19, 2024
@github-actions github-actions bot removed the Workflows Pod Issues that the workflows team owns label Sep 19, 2024
@infinitetrooper infinitetrooper added Workflows Product Issues related to the workflows product Workflows Pod Issues that the workflows team owns and removed Workflows labels Sep 19, 2024
@nsarupr nsarupr changed the title Add linter when a user uses {{appsmith.user.xyz}} binding in workflow code Add linter when a user uses {{appsmith.xyz}} binding in workflow code Sep 23, 2024
@nsarupr nsarupr mentioned this issue Sep 23, 2024
Closed
@nsarupr nsarupr changed the title Add linter when a user uses {{appsmith.xyz}} binding in workflow code Add linter when a user uses {{appsmith.xyz}} binding in workflow code and JS library usage Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayushpahwa ayushpahwa

Labels
Enhancement New feature or request Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ayushpahwa @infinitetrooper