Skip to content

Commit 782c7b0

Browse files
hetunandutrishaanand
authored andcommitted
fix: remove counter of cmd + click navigation usage (#31830)
## Description Fixes the blocker issue for canvas resize by removing the counter of cmd + click as that goes to local storage and that is somehow causing this issue Fixes #31820 ## Automation /ok-to-test tags="@tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8293559664> > Commit: `00eee43d89c9df1071a3a1daca449629e48386ca` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8293559664&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the widget selection process by streamlining the tracking and storage method within the application. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 7ccc687 commit 782c7b0

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

app/client/src/sagas/WidgetSelectionSagas.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ import type { FeatureFlags } from "@appsmith/entities/FeatureFlag";
6161
import { getWidgetSelectorByWidgetId } from "selectors/layoutSystemSelectors";
6262
import { getAppViewerPageIdFromPath } from "@appsmith/pages/Editor/Explorer/helpers";
6363
import AnalyticsUtil from "../utils/AnalyticsUtil";
64-
import {
65-
retrieveCodeWidgetNavigationUsed,
66-
storeCodeWidgetNavigationUsed,
67-
} from "../utils/storage";
6864

6965
// The following is computed to be used in the entity explorer
7066
// Every time a widget is selected, we need to expand widget entities
@@ -220,9 +216,6 @@ function* appendSelectedWidgetToUrlSaga(
220216
const isWidgetSelectionBlocked: boolean = yield select(
221217
getWidgetSelectionBlock,
222218
);
223-
const timesUsedCodeModeWidgetSelection: number = yield call(
224-
retrieveCodeWidgetNavigationUsed,
225-
);
226219
const appMode: APP_MODE = yield select(getAppMode);
227220
const viewMode = appMode === APP_MODE.PUBLISHED;
228221
if (isSnipingMode || viewMode) return;
@@ -243,12 +236,6 @@ function* appendSelectedWidgetToUrlSaga(
243236
});
244237
if (invokedBy === NavigationMethod.CanvasClick && isWidgetSelectionBlocked) {
245238
AnalyticsUtil.logEvent("CODE_MODE_WIDGET_SELECTION");
246-
if (timesUsedCodeModeWidgetSelection < 2) {
247-
yield call(
248-
storeCodeWidgetNavigationUsed,
249-
timesUsedCodeModeWidgetSelection + 1,
250-
);
251-
}
252239
}
253240
if (currentURL !== newUrl) {
254241
history.push(newUrl, { invokedBy });

0 commit comments

Comments
 (0)