Skip to content

Commit 6e6eb25

Browse files
mohanarpitsharat87
authored andcommitted
Removing the keep-alive ping check for CI builds (#565)
1 parent 2677003 commit 6e6eb25

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

.github/workflows/client.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ jobs:
137137
--env APPSMITH_REDIS_URL=redis://localhost:6379 \
138138
--env APPSMITH_ENCRYPTION_PASSWORD=password \
139139
--env APPSMITH_ENCRYPTION_SALT=salt \
140+
--env APPSMITH_IS_SELF_HOSTED=false \
140141
appsmith/appsmith-server:release
141142
142143
- name: Installing Yarn serve

.github/workflows/server.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ jobs:
5858
APPSMITH_REDIS_URL: "redis://127.0.0.1:6379"
5959
APPSMITH_ENCRYPTION_PASSWORD: "password"
6060
APPSMITH_ENCRYPTION_SALT: "salt"
61+
APPSMITH_IS_SELF_HOSTED: false
6162
run: mvn -B package
6263

6364
# Here, the GITHUB_REF is of type /refs/head/<branch_name>. We extract branch_name from this by removing the

app/client/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,4 +82,4 @@ This section has moved here: https://facebook.github.io/create-react-app/docs/tr
8282

8383
### Cypress tests via Github Actions
8484

85-
The cypress tests run via Github actions pull the `release` Docker image of the server to run as a service locally. This is to ensure that we don't face any network flakiness during tests.
85+
The cypress tests run via Github Actions. The Github Action pulls the `release` Docker image of the server to run as a service locally. This is to ensure that we don't face any network flakiness during tests.

app/server/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ In order to test the code, you can run the following command
3030
mvn -B clean package
3131
```
3232

33-
Please make sure that you have a local Redis instance running for the test cases. The MongoDB is run in-memory during tests so that shouldn't be a problem.
33+
Please make sure that you have a local Redis instance running for the test cases. During tests, the MongoDB is run in-memory. So you don't require to be running a local MongoDB instance.

0 commit comments

Comments
 (0)