chore: Remove upsert in setting last release notes version (#31324)

Instead of `upsert`, we `update` first, which is arguably the most used
operation in this context, and if that fails, then we attempt an insert.

We're not expecting a performance hit, since most operations here would
be an actual `update` only.

Author: sharat87

app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/CustomUserDataRepositoryCE.java

@@ -8,7 +8,7 @@
 
 public interface CustomUserDataRepositoryCE extends AppsmithRepository<UserData> {
 
-    Mono<Void> saveReleaseNotesViewedVersion(String userId, String version);
+    Mono<Integer> saveReleaseNotesViewedVersion(String userId, String version);
 
     Mono<Void> removeIdFromRecentlyUsedList(String userId, String workspaceId, List<String> applicationIds);
 

app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/CustomUserDataRepositoryCEImpl.java

@@ -14,8 +14,6 @@
 import java.util.List;
 
 import static com.appsmith.server.helpers.ce.bridge.Bridge.bridge;
-import static org.springframework.data.mongodb.core.query.Criteria.where;
-import static org.springframework.data.mongodb.core.query.Query.query;
 
 public class CustomUserDataRepositoryCEImpl extends BaseAppsmithRepositoryImpl<UserData>
         implements CustomUserDataRepositoryCE {
@@ -28,14 +26,10 @@ public CustomUserDataRepositoryCEImpl(
     }
 
     @Override
-    public Mono<Void> saveReleaseNotesViewedVersion(String userId, String version) {
-        return mongoOperations
-                .upsert(
-                        query(where(UserData.Fields.userId).is(userId)),
-                        Update.update(UserData.Fields.releaseNotesViewedVersion, version)
-                                .setOnInsert(UserData.Fields.userId, userId),
-                        UserData.class)
-                .then();
+    public Mono<Integer> saveReleaseNotesViewedVersion(String userId, String version) {
+        return queryBuilder()
+                .criteria(bridge().equal(UserData.Fields.userId, userId))
+                .updateFirst(Update.update(UserData.Fields.releaseNotesViewedVersion, version));
     }
 
     @Override

app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/UserDataServiceCEImpl.java

@@ -174,7 +174,17 @@ public Mono<User> setViewedCurrentVersionReleaseNotes(User user, String version)
                         .getDefaultTenantId()
                         .flatMap(tenantId -> userRepository.findByEmailAndTenantId(user.getEmail(), tenantId))
                         .flatMap(user1 -> Mono.justOrEmpty(user1.getId())))
-                .flatMap(userId -> repository.saveReleaseNotesViewedVersion(userId, version))
+                .flatMap(userId -> repository
+                        .saveReleaseNotesViewedVersion(userId, version)
+                        .flatMap(count -> {
+                            if (count == 0) {
+                                final UserData userData = new UserData();
+                                userData.setReleaseNotesViewedVersion(version);
+                                userData.setUserId(user.getId());
+                                return repository.save(userData).then();
+                            }
+                            return Mono.empty();
+                        }))
                 .thenReturn(user);
     }