Skip to content

Conversation

@renep
Copy link
Contributor

@renep renep commented Apr 24, 2025

Description

When the Xcode project uses folder for the sources then the command.sh needs to be removed after the diff tool was started. Otherwise a second unit test run from Xcode results in an error because Xcode does not know what to do with the command.sh file.

Summary by Sourcery

Modify the iOS Approvals Watcher to remove the command.sh script after launching the diff tool to prevent Xcode unit test run errors

Bug Fixes:

  • Resolve Xcode unit test run issues caused by lingering command.sh files when using folder-based source configurations

Enhancements:

  • Add a short delay and automatic removal of the command.sh script after launching the diff tool

needs to be removed after the diff tool was started. Otherwise a second
unit test run from xcode results in an error because Xcode does not
know what to do with the command.sh file.
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 24, 2025

Reviewer's Guide by Sourcery

This pull request updates the iOSApprovalsWatcher.py script to ensure that the temporary command.sh file is removed after the diff tool is launched. This prevents errors during subsequent unit test runs in Xcode projects that use folders for sources.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Ensure command.sh is deleted after launching the diff tool to prevent errors on repeated test runs.
  • Added a short delay after starting the diff tool to allow it to initialize.
  • Removed the command.sh file after the diff tool has been started.
iOSApprovalsWatcher.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant