Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read .gitignore for excludes #34

Closed
joelgriffith opened this issue Jul 10, 2015 · 3 comments
Closed

Read .gitignore for excludes #34

joelgriffith opened this issue Jul 10, 2015 · 3 comments

Comments

@joelgriffith
Copy link
Contributor

No description provided.

@laggingreflex
Copy link
Contributor

laggingreflex commented Oct 11, 2016

Fixed in #46

@laggingreflex
Copy link
Contributor

This doesn't yet work exactly like .gitignore. While the gitignore files are parsed correctly, chokidar's ignored option works slightly differently that git's mechanism of ignoring paths from gitignore.

For example it doesn't work on a deeper level. If you have .cache in your .gitignore and src/something/.cache it won't be ignored. It'll only ignore ./cache (from root)

This has come up before too in #47 but I think this particular detail was missed earlier.

I think at least a warning should be added that while sicksync does parse gitignore it doesn't work exactly like it.

Or it should try to make it work? In the above example if I wanted .cache to be ignored a level deeper I'd have to make the rule **/.cache/**, so should it just add **/ before every gitigore rule? I remember I made a PR for doing exactly this in paulmillr/chokidar#539 but, at least from chokidar's perspective, it might not have been a good idea.

What would be the best approach?

@laggingreflex
Copy link
Contributor

laggingreflex commented Feb 23, 2017

This also doesn't work for bigSync (at all, not just the issue in above comment)

edit: fixed in #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants