Skip to content

Commit 92ec42c

Browse files
committed
fix(web): apply size for charts
1 parent c91b5cf commit 92ec42c

File tree

2 files changed

+28
-81
lines changed

2 files changed

+28
-81
lines changed

packages/web/src/components/chart/ReactiveChart.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,14 @@ class ReactiveChart extends React.Component {
7070

7171
if (props.chartType === ChartTypes.Custom) {
7272
if (typeof props.defaultQuery !== 'function' || typeof props.setOption !== 'function') {
73-
throw new Error('defaultQuery and setOption should be defined when chartType is custom');
73+
throw new Error(
74+
'defaultQuery and setOption should be defined when chartType is custom',
75+
);
7476
}
7577
if (props.useAsFilter && typeof props.customQuery !== 'function') {
76-
throw new Error('customQuery should be defined when chartType is custom and useAsFilter is true');
78+
throw new Error(
79+
'customQuery should be defined when chartType is custom and useAsFilter is true',
80+
);
7781
}
7882
}
7983
}
@@ -751,14 +755,21 @@ const ForwardRefComponent = React.forwardRef((props, ref) => (
751755
type = 'search';
752756
}
753757
}
758+
let aggregationSize = preferenceProps.aggregationSize;
759+
if (!aggregationSize) {
760+
if (!type || type === 'term') {
761+
aggregationSize = preferenceProps.size;
762+
}
763+
}
754764
return (
755765
<ComponentWrapper
756766
{...preferenceProps}
757767
type={type}
758768
internalComponent
759769
componentType={componentTypes.reactiveChart}
760-
showHistogram={preferenceProps.type === 'range'}
770+
showHistogram={type === 'range'}
761771
setReact={false}
772+
aggregationSize={aggregationSize}
762773
>
763774
{() => (
764775
<ConnectedComponent {...preferenceProps} type={type} myForwardedRef={ref} />

yarn.lock

Lines changed: 14 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@
6060
dependencies:
6161
cross-fetch "^3.0.4"
6262

63-
"@appbaseio/designkit@^0.13.0":
64-
version "0.13.0"
65-
resolved "https://registry.yarnpkg.com/@appbaseio/designkit/-/designkit-0.13.0.tgz#79e184cb7ed283c7a07ccc7c75d8a3236a58b7ea"
66-
integrity sha512-qZSXG1vrhUflrQUFhEDxT/iAdBZc75YNhyEg69nzQipRkDJVvj0cRo2D4CSLHWBjznKB9eMAY8oNq/LmFAMBJQ==
63+
"@appbaseio/designkit@^0.11.0":
64+
version "0.11.0"
65+
resolved "https://registry.yarnpkg.com/@appbaseio/designkit/-/designkit-0.11.0.tgz#6f0fce707239a8255ef3127b5889703368773cb8"
66+
integrity sha512-qX5Ych7sgPKl4IP7jWiT7ISalDpky7IMS9fNxDH/M9rDsJ46AZABaC8xnuODWQPWtA0qHbW35TWltFxjfQ5TJA==
6767
dependencies:
6868
"@storybook/react" "^3.2.19"
6969
prop-types "^15.6.0"
@@ -141,17 +141,6 @@
141141
react-router-dom "4.3.1"
142142
tocbot "4.5.0"
143143

144-
"@appbaseio/[email protected]":
145-
version "9.14.19"
146-
resolved "https://registry.yarnpkg.com/@appbaseio/reactivecore/-/reactivecore-9.14.19.tgz#bf7032f3ece40ed512b471a03280c68724b45249"
147-
integrity sha512-hhg5NwmtqsWSJCPv4xb9mQ9rycVQqRMwDelKwEa1lFaCmuEGAfHuL+2OR021wbq36suiIXvX1eT9TFy4ZJGdZQ==
148-
dependencies:
149-
cross-fetch "^3.0.4"
150-
prop-types "^15.6.0"
151-
redux "^4.0.0"
152-
redux-thunk "^2.3.0"
153-
xdate "^0.8.2"
154-
155144
"@appbaseio/[email protected]":
156145
version "1.16.0-alpha.63"
157146
resolved "https://registry.yarnpkg.com/@appbaseio/reactivesearch-vue/-/reactivesearch-vue-1.16.0-alpha.63.tgz#6e8a131607c6d85d45a0ff966d6bea8cceb56544"
@@ -174,31 +163,6 @@
174163
vue-slider-component "^3.2.15"
175164
vue-types "^1.7.0"
176165

177-
"@appbaseio/[email protected]":
178-
version "3.38.2"
179-
resolved "https://registry.yarnpkg.com/@appbaseio/reactivesearch/-/reactivesearch-3.38.2.tgz#13124dafd71486075c835d7c867d3e2767b45e00"
180-
integrity sha512-HUXw8leJMk5I5Eekipl9ny2mVu2KyLmmBxat/lRIM7YAdPqXTNrEA1zJEbIXDtXN4RKyK+4u+x+gF+vtUSmRgA==
181-
dependencies:
182-
"@appbaseio/reactivecore" "9.14.19"
183-
"@emotion/core" "^10.0.28"
184-
"@emotion/styled" "^10.0.27"
185-
appbase-js "5.0.0"
186-
cross-env "^5.2.0"
187-
downshift "^1.31.2"
188-
echarts "^5.3.3"
189-
echarts-for-react "^3.0.2"
190-
emotion-theming "^10.0.27"
191-
hoist-non-react-statics "^3.2.1"
192-
hotkeys-js "^3.8.7"
193-
polished "^1.9.3"
194-
prop-types "^15.6.0"
195-
react-day-picker "^7.0.5"
196-
react-redux "^6.0.1"
197-
rheostat "^2.1.1"
198-
url-search-params-polyfill "^7.0.0"
199-
xdate "^0.8.2"
200-
xss "^1.0.11"
201-
202166
"@appbaseio/[email protected]":
203167
version "0.4.4"
204168
resolved "https://registry.yarnpkg.com/@appbaseio/vue-emotion/-/vue-emotion-0.4.4.tgz#a2187691a5dce090a8571250c1a7911d2ceee58a"
@@ -5225,19 +5189,6 @@
52255189
resolved "https://registry.yarnpkg.com/@turist/time/-/time-0.0.2.tgz#32fe0ce708ea0f4512776bd313409f1459976dda"
52265190
integrity sha512-qLOvfmlG2vCVw5fo/oz8WAZYlpe5a5OurgTj3diIxJCdjRHpapC+vQCz3er9LV79Vcat+DifBjeAhOAdmndtDQ==
52275191

5228-
"@typeform/embed-react@^1.13.0":
5229-
version "1.19.0"
5230-
resolved "https://registry.yarnpkg.com/@typeform/embed-react/-/embed-react-1.19.0.tgz#e67eefd10681d8a04672cacbf3395e862f93c470"
5231-
integrity sha512-mzcJrHOIgNh3Kr8HuOlG6IptoaDcFZ7QYy3ZI8KRMKEf8VlZyiMn6v0sRbgjpJV+V0v3gzKfhxBBu5KBZP1OMw==
5232-
dependencies:
5233-
"@typeform/embed" "1.37.0"
5234-
fast-deep-equal "^3.1.3"
5235-
5236-
"@typeform/[email protected]", "@typeform/embed@^1.34.1":
5237-
version "1.37.0"
5238-
resolved "https://registry.yarnpkg.com/@typeform/embed/-/embed-1.37.0.tgz#33ea95e30456568269735062c704597a9b443b03"
5239-
integrity sha512-8GcABMWz/hrMLojoumjnvZxPcANwvZqvXPKAinH6KGEKZw3RFni9zHdPNxl1cJoexuq09rBDIfRgNmvSU8EsUQ==
5240-
52415192
"@types/babel__core@^7.1.0":
52425193
version "7.1.19"
52435194
resolved "https://registry.yarnpkg.com/@types/babel__core/-/babel__core-7.1.19.tgz#7b497495b7d1b4812bdb9d02804d0576f43ee460"
@@ -6891,11 +6842,6 @@ acorn@^8.0.4, acorn@^8.5.0, acorn@^8.7.1:
68916842
resolved "https://registry.yarnpkg.com/acorn/-/acorn-8.8.0.tgz#88c0187620435c7f6015803f5539dae05a9dbea8"
68926843
integrity sha512-QOxyigPVrpZ2GXT+PFyZTl6TtOFc5egxHIP9IlQ+RbupQuX4RkT/Bee4/kQuC02Xkzg84JcT7oLYtDIQxp+v7w==
68936844

6894-
add@^2.0.6:
6895-
version "2.0.6"
6896-
resolved "https://registry.yarnpkg.com/add/-/add-2.0.6.tgz#248f0a9f6e5a528ef2295dbeec30532130ae2235"
6897-
integrity sha512-j5QzrmsokwWWp6kUcJQySpbG+xfOBqqKnup3OIk1pz+kB/80SLorZ9V8zHFLO92Lcd+hbvq8bT+zOGoPkmBV0Q==
6898-
68996845
69006846
version "1.0.3"
69016847
resolved "https://registry.yarnpkg.com/address/-/address-1.0.3.tgz#b5f50631f8d6cec8bd20c963963afb55e06cbce9"
@@ -7316,15 +7262,6 @@ app-root-dir@^1.0.2:
73167262
resolved "https://registry.yarnpkg.com/app-root-dir/-/app-root-dir-1.0.2.tgz#38187ec2dea7577fff033ffcb12172692ff6e118"
73177263
integrity sha512-jlpIfsOoNoafl92Sz//64uQHGSyMrD2vYG5d8o2a4qGvyNCvXur7bzIsWtAC/6flI2RYAp3kv8rsfBtaLm7w0g==
73187264

7319-
[email protected], appbase-js@^5.0.0:
7320-
version "5.0.0"
7321-
resolved "https://registry.yarnpkg.com/appbase-js/-/appbase-js-5.0.0.tgz#9f3e25ad718251e153593f7559cfac7b4d4ac961"
7322-
integrity sha512-TOvBaXEpRd85Oo118X+NNQq7CMtZE3eyp7zYWZ7LO2o9mrdTQRUk+ADE0P8xFkga2c4WHHRyBhoeJglux12LZg==
7323-
dependencies:
7324-
cross-fetch "^3.1.5"
7325-
querystring "^0.2.0"
7326-
url-parser-lite "^0.1.0"
7327-
73287265
[email protected], appbase-js@^5.1.0:
73297266
version "5.1.0"
73307267
resolved "https://registry.yarnpkg.com/appbase-js/-/appbase-js-5.1.0.tgz#6896fad28376ee4d43ca03042e7c426e767eeed0"
@@ -7343,6 +7280,15 @@ appbase-js@^4.0.2-beta.11:
73437280
querystring "^0.2.0"
73447281
url-parser-lite "^0.1.0"
73457282

7283+
appbase-js@^5.0.0:
7284+
version "5.0.0"
7285+
resolved "https://registry.yarnpkg.com/appbase-js/-/appbase-js-5.0.0.tgz#9f3e25ad718251e153593f7559cfac7b4d4ac961"
7286+
integrity sha512-TOvBaXEpRd85Oo118X+NNQq7CMtZE3eyp7zYWZ7LO2o9mrdTQRUk+ADE0P8xFkga2c4WHHRyBhoeJglux12LZg==
7287+
dependencies:
7288+
cross-fetch "^3.1.5"
7289+
querystring "^0.2.0"
7290+
url-parser-lite "^0.1.0"
7291+
73467292
append-field@^1.0.0:
73477293
version "1.0.0"
73487294
resolved "https://registry.yarnpkg.com/append-field/-/append-field-1.0.0.tgz#1e3440e915f0b1203d23748e78edd7b9b5b43e56"
@@ -16971,11 +16917,6 @@ [email protected]:
1697116917
unist-util-select "^3.0.4"
1697216918
unist-util-visit-parents "^3.1.1"
1697316919

16974-
gatsby-remark-prismjs-copy-button@^0.3.1:
16975-
version "0.3.1"
16976-
resolved "https://registry.yarnpkg.com/gatsby-remark-prismjs-copy-button/-/gatsby-remark-prismjs-copy-button-0.3.1.tgz#5d772d64b4fce0bee417c7ea7fe39b5a34403d62"
16977-
integrity sha512-/A3BuZSdmI62+uSitAbgqdoS3QtYX4kiz9DZZgc1qMqpPss07YTmU8dFuVNxnNDP13h9jAMfr3BxP7J60ATZSg==
16978-
1697916920
1698016921
version "6.9.0"
1698116922
resolved "https://registry.yarnpkg.com/gatsby-remark-prismjs/-/gatsby-remark-prismjs-6.9.0.tgz#deebda74c244adc20ea8e524983221c38a326e72"
@@ -28940,7 +28881,7 @@ react-responsive-modal@^4.0.1:
2894028881
prop-types "^15.6.2"
2894128882
react-transition-group "^4.0.0"
2894228883

28943-
react-router-dom@^4.2.2, react-router-dom@^4.3.1:
28884+
react-router-dom@4.3.1, react-router-dom@^4.2.2:
2894428885
version "4.3.1"
2894528886
resolved "https://registry.yarnpkg.com/react-router-dom/-/react-router-dom-4.3.1.tgz#4c2619fc24c4fa87c9fd18f4fb4a43fe63fbd5c6"
2894628887
integrity sha512-c/MlywfxDdCp7EnB7YfPMOfMD3tOtIjrQlj/CKfNMBxdmpJP8xcz5P/UAFn3JbnQCNUxsHyVVqllF9LhgVyFCA==
@@ -35675,11 +35616,6 @@ yargs@~3.10.0:
3567535616
decamelize "^1.0.0"
3567635617
window-size "0.1.0"
3567735618

35678-
yarn@^1.22.18:
35679-
version "1.22.19"
35680-
resolved "https://registry.yarnpkg.com/yarn/-/yarn-1.22.19.tgz#4ba7fc5c6e704fce2066ecbfb0b0d8976fe62447"
35681-
integrity sha512-/0V5q0WbslqnwP91tirOvldvYISzaqhClxzyUKXYxs07yUILIs5jx/k6CFe8bvKSkds5w+eiOqta39Wk3WxdcQ==
35682-
3568335619
3568435620
version "0.1.2"
3568535621
resolved "https://registry.yarnpkg.com/yeast/-/yeast-0.1.2.tgz#008e06d8094320c372dbc2f8ed76a0ca6c8ac419"

0 commit comments

Comments
 (0)