Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS ISSUE] Page: Page Templates #302

Open
pwohlschl opened this issue Aug 8, 2020 · 3 comments
Open

[DOCS ISSUE] Page: Page Templates #302

pwohlschl opened this issue Aug 8, 2020 · 3 comments
Assignees

Comments

@pwohlschl
Copy link

The documentation invites to edit "app.js", when actually the file to update is the relevant "index.js".

@abea abea self-assigned this Aug 14, 2020
@abea
Copy link
Contributor

abea commented Aug 17, 2020

Are you referring to "### Example: Adding a Page Template to app.js"? That is true, but not the best practice. I'll update that. Please let me know if you're talking about another specific reference.

@abea
Copy link
Contributor

abea commented Aug 17, 2020

Also "2. Register the new page template in app.js". The same applies but, again, it's not the best practice anymore.

@pwohlschl
Copy link
Author

Correct, I first came across this issue whilst going through the tutorials online. I spotted it on a few occasions on "Page Templates":

  • "2. Register the new page template in app.js"
  • "Now that you have a default.html file, you need to register it in app.js to make it available."
  • "#Example: Adding a Page Template to app.js"

I think this change in best practice might have impacted other parts of the documentation, e.g. in the "Building Navigation" pages, I also read "first, in app.js, let's configure apostrophe-pages to retrieve two levels of children when fetching ancestors of the current page".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants