Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-ios-xcframework doesn't add bundle identifier to the Info.plist for the created xcframework #3425

Closed
Karram-Ayman opened this issue Aug 14, 2024 · 2 comments · Fixed by apollographql/apollo-ios-xcframework#18
Labels
bug Generally incorrect behavior needs investigation

Comments

@Karram-Ayman
Copy link

Summary

The apollo-ios-xcframework does not automatically add a CFBundleIdentifier to the Info.plist files of the created XCFrameworks when using the provided Makefile script. As a result, when you try to link Apollo.xcframework and ApolloAPI.xcframework in an Xcode project using the "Embed and Sign" option, the build may succeed, but a runtime error will occur. This error indicates that ApolloAPI.framework (or Apollo.framework) is missing a CFBundleIdentifier in its Info.plist, which is required for proper framework embedding.

Screenshot 2024-08-14 at 1 16 05 PM

Version

1.14.1

Steps to reproduce the behavior

  1. Following the make script to create xcframework in https://github.com/apollographql/apollo-ios-xcframework
  2. Add created xcframework to Xcode project link frameworks target with embed & Sign
  3. Run the project

Logs

Payload/MyProject.app/Frameworks/ApolloAPI.framework did not have a CFBundleIdentifier in its Info.plist

Anything else?

No response

@BobaFetters
Copy link
Member

Thanks for the report @Karram-Ayman have a PR up that should resolve this apollographql/apollo-ios-xcframework#18

Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Generally incorrect behavior needs investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants