Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back mergeInFieldsFromFragmentSpreads functionality. #2625

Closed
jimisaacs opened this issue Oct 31, 2022 · 1 comment
Closed

Add back mergeInFieldsFromFragmentSpreads functionality. #2625

jimisaacs opened this issue Oct 31, 2022 · 1 comment

Comments

@jimisaacs
Copy link
Contributor

jimisaacs commented Oct 31, 2022

Feature request

Add back mergeInFieldsFromFragmentSpreads functionality. Based on the text here, it sounds like it is possible https://github.com/apollographql/apollo-ios/blob/main/CodegenProposal.md#fragment-fields-are-always-merged-in.

Motivation

There is a part of our supergraph where the use of mergeInFieldsFromFragmentSpreads is very much a mitigation. Now after the Apollo 1.0 upgrade, we are not really seeing a reduction in codegen size over time, but maybe even an increase. For example, there was just a few lines of GraphQL at the top-level added, but it had many fragment depths which altogether increased codegen by 2206 lines.

Proposed solution

Implement what is suggested here https://github.com/apollographql/apollo-ios/blob/main/CodegenProposal.md#fragment-fields-are-always-merged-in

@calvincestari
Copy link
Member

Hiya @jimisaacs - we're aware of the issue and are tracking it's progress in #2560 - see this comment. I'm going to close this issue as a duplicate but link to it in #2560 so we know it has increased priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants