Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_lines has no color by default #169

Open
keflavich opened this issue Feb 11, 2014 · 4 comments
Open

show_lines has no color by default #169

keflavich opened this issue Feb 11, 2014 · 4 comments

Comments

@keflavich
Copy link
Member

Noted in aplpy/aplpy-examples#1, apparently show_lines defaults to no color. There is no obvious reason for this that I can see in the source for show_lines or LineCollection:

F.show_grayscale()
F.show_lines([np.array([[265,267],[-28,-30]])]) # shows nothing
F.show_lines([np.array([[265,267],[-28,-30]])],color='r')
@neuronphysics
Copy link

In the input list of arrays of show_lines() do you provide the first component of np.array as all the right ascensions and the second one the declinations? because I got confused with the order of input file with this example!

@keflavich
Copy link
Member Author

@neuronphysics: Your question isn't relevant to this issue, so could you please post it on the astropy examples page instead? Yes, the order is always ra,dec

@gully
Copy link

gully commented Sep 22, 2016

I love open source. I was at wit's end to help a graduate student who asked me why show_lines( wasn't working, I typed that substring into GitHub search and voilà: answer is here.
So I guess thank you all for contributing to open source and making this dialog public to help others. Although the default of no color seems like a bug, right?

@keflavich
Copy link
Member Author

@gully yes, I think this is fair to regard as a bug. The user should either be warned that no color is selected or there should be a default color. A pull request fixing the issue would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants