Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BdbDB potential ObjectLocks issues #36

Open
tmagrino opened this issue Apr 18, 2019 · 0 comments
Open

BdbDB potential ObjectLocks issues #36

tmagrino opened this issue Apr 18, 2019 · 0 comments
Labels
bug

Comments

@tmagrino
Copy link
Member

Right now, BdbDB's handling of pending and prepared (but not commited) transactions is not correctly managing ObjectLocks and can potentially experience deadlocks.
@tmagrino tmagrino added the bug label Apr 18, 2019
This was referenced Jul 22, 2019
Closed
Open
tmagrino added a commit that referenced this issue Jul 23, 2019
@tmagrino
Strip down the implementation of BDB to address some bad interactions
cab2946 
between the Fabric Store locks and the bdb locks.

This strips out a lot of pending transaction tables, which probably were
meant to help with recovering partial transactions after a failure.
However, we never implemented recovery protocols to use it and removing
it doesn't make the failure tolerance/recovery story any better/worse
than the MemoryDB implementation.  So, for now, let's run with the
simplified implementation.

This should address #36, will close if I confirm it works after some
testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmagrino