Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some messages do not take advantage of "InProcess" nodes. #15

Open
tmagrino opened this issue Jan 29, 2018 · 0 comments
Open

Some messages do not take advantage of "InProcess" nodes. #15

tmagrino opened this issue Jan 29, 2018 · 0 comments

Comments

@tmagrino
Copy link
Member

There are a few messages between Workers to Stores that are sent through a socket despite being in the same process. Currently this applies to the messages MakePrincipalMessage and AllocateMessage.

This boils down to an issue of it being easy to forget to add specialized support for messages to InProcess Nodes like InProcessStore and InProcessRemoteWorker.

In the short term, we should check to see if we want to change these messages to also have specialized behavior. In the longer term, it might be worth seeing if there's a way to make it harder to forget to add specialized handling when adding a new message type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant