preserve order of has_many field values - closes #9

Author: GarPit

app/assets/javascripts/kms_models/application/controllers/entries_controller.coffee.erb

@@ -27,8 +27,9 @@ EntriesController = ($scope, $state, Restangular, $stateParams, Alertify, Errors
 
   $scope.initAssociationField = (field)->
     if field.type == 'Kms::HasManyField'
-      $scope.entry.values[field.liquor_name] = _.filter $scope[field.liquor_name], (element)->
-        _.contains $scope.entry.values[field.liquor_name], element.id.toString()
+      fieldEntries = _.map $scope.entry.values[field.liquor_name], (entryId)->
+        _.find $scope[field.liquor_name], { 'id': parseInt(entryId) }
+      $scope.entry.values[field.liquor_name] = _.compact fieldEntries
     else
       $scope.entry.values[field.liquor_name] = _.find $scope[field.liquor_name], (element)->
         $scope.entry.values[field.liquor_name] == element.id.toString()
@@ -65,16 +66,16 @@ EntriesController = ($scope, $state, Restangular, $stateParams, Alertify, Errors
     if $scope.entry.slug
       fd.append("entry[slug]", $scope.entry.slug)
     for key, value of $scope.entry.values
-      continue if value == undefined
-      if value
+      # continue if value == undefined
+      unless _.isEmpty(value)
         if value.constructor.name == 'Array'
           for element in value
             id = if element.constructor.name == 'Object' then element.id else element
             fd.append("entry[values][#{key}][]", id)
         else if value.constructor.name != 'Object'
           fd.append("entry[values][#{key}]", value || '')
       else
-        fd.append("entry[values][#{key}]", value || '')
+        fd.append("entry[values][#{key}]", if value? then value else '')
     $scope.entry.withHttpConfig({ transformRequest: angular.identity }).post('', fd, '', {"Content-Type": undefined}).then ->
       $state.go('models.entries', modelId: $scope.model.id)
     ,(response)->

app/models/kms/has_many_field.rb

@@ -3,6 +3,13 @@ class HasManyField < Field
     def get_value(entry)
       entry_ids = entry.values[liquor_name]
       association_records = Kms::Entry.where(id: entry_ids)
+      if entry_ids.present?
+        # this one allows ORDER BY the IN value list like this example:
+        # SELECT * FROM "comments" WHERE ("comments"."id" IN (1,3,2,4))
+        # ORDER BY  id=1 DESC, id=3 DESC, id=2 DESC, id=4 DESC
+        order_sql = entry_ids.map {|entry_id| "id=#{entry_id} DESC"}
+        association_records = association_records.order(order_sql.join(','))
+      end
       Liquor::DropDelegation.wrap_scope(association_records)
     end
   end