Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for import errors where there is missing extra #838

Open
vdusek opened this issue Dec 20, 2024 · 1 comment
Open

Add tests for import errors where there is missing extra #838

vdusek opened this issue Dec 20, 2024 · 1 comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@vdusek
Copy link
Collaborator

vdusek commented Dec 20, 2024

Problem

  • The test_import_error_handled is currently not functional with the new crawlee._utils.try_import.ImportWrapper.
  • As a result, the test is marked as skipped.

Solution

  • Come up with a way to ensure that ImportError is properly raised when required extras are missing.
  • Extend this testing approach to cover all extras - parsel, beautifulsoup, playwright, and curl-impersonate.
@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 20, 2024
@janbuchar
Copy link
Collaborator

We might want to take care of this on the CI level - I imagine we could run a part of the tests with the extras uninstalled as a separate step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants