-
Notifications
You must be signed in to change notification settings - Fork 508
Closed
Closed
Copy link
Labels
t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.
Description
Recently, tests like this started crashing in Pytest more frequently.
[gw1] win32 -- Python 3.10.11 D:\a\crawlee-python\crawlee-python\.venv\Scripts\python.exe
worker 'gw1' crashed while running 'tests/unit/_utils/test_sitemap.py::test_gzipped_sitemap_with_invalid_data[curl]'
________________ tests/unit/http_clients/test_http_clients.py _________________
[gw0] win32 -- Python 3.10.11 D:\a\crawlee-python\crawlee-python\.venv\Scripts\python.exe
worker 'gw0' crashed while running 'tests/unit/http_clients/test_http_clients.py::test_stream[curl]'
______________________ tests/unit/_utils/test_sitemap.py ______________________
[gw2] win32 -- Python 3.10.11 D:\a\crawlee-python\crawlee-python\.venv\Scripts\python.exe
worker 'gw2' crashed while running 'tests/unit/_utils/test_sitemap.py::test_xml_sitemap_with_gzipped_data[curl]'
Those tests are crashing only for a specific parameter that is related to curl_cffi and only on Windows and Python 3.10. While there is no good log to investigate the issue, it could be potentially related to curl_cffi not having an upper boundary on version for cffi, which recently released a new major version 2.0.0.
Maybe a temporary fix could be limiting cffi version to <2.0.0 and reporting the issue to the upstream repo for investigation.
Metadata
Metadata
Assignees
Labels
t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.