chore: deprecate link_security and set it default to true

Author: Maxcastel

src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -995,9 +995,7 @@ private function registerArgumentResolverConfiguration(PhpFileLoader $loader): v
 
     private function registerLinkSecurityConfiguration(PhpFileLoader $loader, array $config): void
     {
-        if ($config['enable_link_security']) {
-            $loader->load('link_security.php');
-        }
+        $loader->load('link_security.php');
     }
 
     private function registerJsonStreamerConfiguration(ContainerBuilder $container, PhpFileLoader $loader, array $formats, array $config): void

src/Symfony/Bundle/DependencyInjection/Configuration.php

@@ -117,7 +117,11 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->booleanNode('enable_docs')->defaultTrue()->info('Enable the docs')->end()
                 ->booleanNode('enable_profiler')->defaultTrue()->info('Enable the data collector and the WebProfilerBundle integration.')->end()
                 ->booleanNode('enable_phpdoc_parser')->defaultTrue()->info('Enable resource metadata collector using PHPStan PhpDocParser.')->end()
-                ->booleanNode('enable_link_security')->defaultFalse()->info('Enable security for Links (sub resources)')->end()
+                ->booleanNode('enable_link_security')
+                    ->defaultTrue()
+                    ->info('Enable security for Links (sub resources).')
+                    ->setDeprecated('api-platform/symfony', '4.2', 'This option is always enabled and will be removed in API Platform 5.0.')
+                ->end()
                 ->arrayNode('collection')
                     ->addDefaultsIfNotSet()
                     ->children()

tests/Fixtures/app/config/config_common.yml

@@ -82,6 +82,7 @@ api_platform:
     http_cache:
         invalidation:
             enabled: true
+    # TODO: remove in 5.0
     enable_link_security: true
     # see also defaults in AppKernel
     doctrine_mongodb_odm: false

tests/Symfony/Bundle/DependencyInjection/ConfigurationTest.php

@@ -233,7 +233,8 @@ private function runDefaultConfigTests(array $doctrineIntegrationsToLoad = ['orm
             ],
             'use_symfony_listeners' => false,
             'handle_symfony_errors' => false,
-            'enable_link_security' => false,
+            // TODO: remove in 5.0
+            'enable_link_security' => true,
             'serializer' => [
                 'hydra_prefix' => null,
             ],