Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesnt work on webkit (touch devices) and android web view #24

Open
razcakappa opened this issue Jun 28, 2017 · 2 comments
Open

Doesnt work on webkit (touch devices) and android web view #24

razcakappa opened this issue Jun 28, 2017 · 2 comments

Comments

@razcakappa
Copy link

razcakappa commented Jun 28, 2017 •
edited
Loading

Tried with Google Chrome Version 59.0.3071.86 (Official Build) (64-bit)
Tried with Android Web View version 58
It stuck on pull down. However it happens only when selects a touch device
http://pix.toile-libre.org/upload/original/1498626667.png
@razcakappa razcakappa changed the title Doesnt work on web kit Doesnt work on webkit and android web view Jun 28, 2017
@razcakappa razcakappa changed the title Doesnt work on webkit and android web view Doesnt work on webkit (touch devices) and android web view Jun 28, 2017
@razcakappa
Copy link
Author

To recreate the issue, open the demo http://apeatling.com/demos/web-ptr/ with Google chrome and open inspect window. and try to reload the page. And try the pull to refresh functionality. It might be broken

@razcakappa
Copy link
Author

razcakappa commented Jul 1, 2017 •
edited
Loading

Found the issue. Might be related to hammer.js is not triggering the 'panend' event when the element has css property 'touch-action: pan-y'.
hammerjs/hammer.js#1103

Shall I submit a merge request?

razcakappa added a commit to razcakappa/web-pull-to-refresh that referenced this issue Jul 1, 2017
@razcakappa
issue apeatling#24 fixed
71dcc02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@razcakappa