Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ptrEl and contentEl options expecting elements, not IDs #11

Open
raglan-road opened this issue Sep 22, 2015 · 0 comments
Open

ptrEl and contentEl options expecting elements, not IDs #11

raglan-road opened this issue Sep 22, 2015 · 0 comments

Comments

@raglan-road
Copy link

According to the documentation, the ptrEl and contentEl options are the IDs of those respective elements. However, the code does not use them as IDs: it never passes them into, say, document.getElementId to fetch the actual elements. This has the side effect of causing Hammer to throw an exception if these parameters are used.

There are two options here: pass in the elements directly (which does not require a code change but might be kind of wonky) or update the code to make sure we're getting elements back. I'll attach a pull request for the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant