TIKA-4220 -- temporary workaround for tar detection regression (#1687)

* TIKA-4220 on branch_2x -- temporary commons-compress workaround
apache · Mar 25, 2024 · 6dd4ac7 · 6dd4ac7
1 parent 9dc037d
commit 6dd4ac7
Show file tree

Hide file tree

Showing 3 changed files with 673 additions and 13 deletions.
diff --git a/...odules/tika-parser-pkg-module/src/main/java/org/apache/tika/parser/pkg/PackageParser.java b/...odules/tika-parser-pkg-module/src/main/java/org/apache/tika/parser/pkg/PackageParser.java
@@ -61,6 +61,7 @@
 
 import org.apache.tika.config.Field;
 import org.apache.tika.detect.EncodingDetector;
+import org.apache.tika.detect.zip.TikaArchiveStreamFactory;
 import org.apache.tika.exception.EncryptedDocumentException;
 import org.apache.tika.exception.TikaException;
 import org.apache.tika.extractor.EmbeddedDocumentExtractor;
@@ -252,18 +253,38 @@ public void parse(InputStream stream, ContentHandler handler, Metadata metadata,
         }
 
         TemporaryResources tmp = new TemporaryResources();
+        try {
+            _parse(stream, handler, metadata, context, tmp);
+        } finally {
+            tmp.close();
+        }
+    }
+
+    private void _parse(InputStream stream, ContentHandler handler, Metadata metadata,
+                ParseContext context, TemporaryResources tmp)
+            throws TikaException, IOException, SAXException {
         ArchiveInputStream ais = null;
         String encoding = null;
         try {
             ArchiveStreamFactory factory =
-                    context.get(ArchiveStreamFactory.class, new ArchiveStreamFactory());
-            encoding = factory.getEntryEncoding();
-            // At the end we want to close the archive stream to release
-            // any associated resources, but the underlying document stream
-            // should not be closed
-
-            ais = factory.createArchiveInputStream(new CloseShieldInputStream(stream));
-
+                    context.get(ArchiveStreamFactory.class);
+            //TODO -- fix this when we next upgrade commons-compress
+            //TODO -- we've probably already detected the stream by here. We should
+            //rely on that detection and not re-detect.
+            if (factory != null) {
+                encoding = factory.getEntryEncoding();
+                // At the end we want to close the archive stream to release
+                // any associated resources, but the underlying document stream
+                // should not be closed
+                ais = factory.createArchiveInputStream(new CloseShieldInputStream(stream));
+            } else {
+                TikaArchiveStreamFactory tikaFactory = new TikaArchiveStreamFactory();
+                encoding = tikaFactory.getEntryEncoding();
+                // At the end we want to close the archive stream to release
+                // any associated resources, but the underlying document stream
+                // should not be closed
+                ais = tikaFactory.createArchiveInputStream(new CloseShieldInputStream(stream));
+            }
         } catch (StreamingNotSupportedException sne) {
             // Most archive formats work on streams, but a few need files
             if (sne.getFormat().equals(ArchiveStreamFactory.SEVEN_Z)) {
@@ -293,11 +314,9 @@ public void parse(InputStream stream, ContentHandler handler, Metadata metadata,
                 // Pending a fix for COMPRESS-269 / TIKA-1525, this bit is a little nasty
                 ais = new SevenZWrapper(sevenz);
             } else {
-                tmp.close();
                 throw new TikaException("Unknown non-streaming format " + sne.getFormat(), sne);
             }
         } catch (ArchiveException e) {
-            tmp.close();
             throw new TikaException("Unable to unpack document stream", e);
         }
 
@@ -329,7 +348,6 @@ public void parse(InputStream stream, ContentHandler handler, Metadata metadata,
             }
         } finally {
             ais.close();
-            tmp.close();
             xhtml.endDocument();
         }
     }

diff --git a/...ser-zip-commons/src/main/java/org/apache/tika/detect/zip/DefaultZipContainerDetector.java b/...ser-zip-commons/src/main/java/org/apache/tika/detect/zip/DefaultZipContainerDetector.java
@@ -25,7 +25,6 @@
 import java.util.List;
 
 import org.apache.commons.compress.archivers.ArchiveException;
-import org.apache.commons.compress.archivers.ArchiveStreamFactory;
 import org.apache.commons.compress.archivers.zip.UnsupportedZipFeatureException;
 import org.apache.commons.compress.archivers.zip.ZipArchiveEntry;
 import org.apache.commons.compress.archivers.zip.ZipArchiveInputStream;
@@ -121,7 +120,9 @@ static MediaType detectArchiveFormat(byte[] prefix, int length) {
             return TIFF;
         }
         try {
-            String name = ArchiveStreamFactory.detect(new UnsynchronizedByteArrayInputStream(prefix, 0, length));
+            String name =
+                    TikaArchiveStreamFactory.detect(new UnsynchronizedByteArrayInputStream(prefix,
+                            0, length));
             return PackageConstants.getMediaType(name);
         } catch (ArchiveException e) {
             return MediaType.OCTET_STREAM;