-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve pdf export quality #31349
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR apparently adds a new requirement. I don't oppose this change, but I would propose the following:
- Add
img2pdf
to one of the.in
files inrequirements/
. Based on this change it would need to go intobase.in
. Also do check that the license is Apache 2.0 compliant. - Add before/after screenshots to show how quality changes.
- Add info about how the pdf file size changed before/after. Lossless compression is great, but can bloat the attachment size.
img2pdf is using GNU Lesser General Public License v3 and it seems that it is not accepted in ASF projects. So need to look for alternative approach then. |
Dang, that's a real shame! 🙁 |
Do we know if the low resolution is caused by the capture method ( |
Resolution does not fix issue. I can get similar quality by setting quality=100 but this results to a pdf that has double the size what img2pdf produces. I will continue my testings... |
FYI I converted this to draft. @tahvane1 please feel free to change it back to non-draft if you find a new ASF-compliant way to fix this issue. |
This PR uses img2pdf to export charts to pdf. Current solutions uses compression in such way that pdf is grainy.
Using img2pdf removes this issue mostly.
SUMMARY
Current pdf quality is poor and this improves it significantly
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
img2pdf needs to be added to docker images.
ADDITIONAL INFORMATION