Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show User: Inconsistent capitalisation on page headings #30515

Closed
3 tasks done
praveer38 opened this issue Oct 4, 2024 · 1 comment
Closed
3 tasks done

Show User: Inconsistent capitalisation on page headings #30515

praveer38 opened this issue Oct 4, 2024 · 1 comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed fab

Comments

@praveer38
Copy link

Bug description

On the Show User page, there is inconsistent capitalisation for the section headings.

User info

Personal Info

Audit Info

“User info” should be changed to “User Info” to keep the capitalisation consistent.
image

Screenshots/recordings

image

Superset version

4.0.2

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added the #bug:cosmetic Cosmetic/layout/design tweak needed label Oct 4, 2024
@sfirke
Copy link
Member

sfirke commented Oct 4, 2024

Hello @praveer38 : this is an issue with Flask-AppBuilder. Superset uses FAB for much of its code, including security. You would need to change the line here and here.

Could you please submit that change as a pull request to that repository? To be complete I guess you should also change https://github.com/dpgaspar/Flask-AppBuilder/blob/1d27eb42a4f9b6e19fb3c025327b4110b175eccb/examples/quickhowto2/app/sec_views.py#L14 and maybe capitalize it in the translations files too. Basically search the repository for "User info" and where exactly that string occurs, make the appropriate substitution.

That's as far as this relates to Superset. I'm going to close this because it's not an actionable bug for this project.

@sfirke sfirke closed this as completed Oct 4, 2024
@apache apache deleted a comment from dosubot bot Oct 4, 2024
@sfirke sfirke added the fab label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed fab
Projects
None yet
Development

No branches or pull requests

2 participants