Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: machine auth for GAQ enabled deployments #29591

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

harshit2283
Copy link
Contributor

SUMMARY

Ensures all after_request decorated functions are called. This allows Reports to work flawlessly with GAQ enabled deployments.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

NA

TESTING INSTRUCTIONS

Enable Global Async Queries and all the supporting params, try generating a report with an image.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added alert-reports Namespace | Anything related to the Alert & Reports feature global:async-query Related to Async Queries feature labels Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (76d897e) to head (faf68a2).
Report is 477 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29591       +/-   ##
===========================================
+ Coverage   60.48%   83.74%   +23.25%     
===========================================
  Files        1931      524     -1407     
  Lines       76236    37782    -38454     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31639    -14475     
+ Misses      28017     6143    -21874     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.12% <0.00%> (-0.05%) ⬇️
javascript ?
mysql 76.99% <100.00%> (?)
postgres 77.07% <100.00%> (?)
presto 53.70% <0.00%> (-0.11%) ⬇️
python 83.74% <100.00%> (+20.25%) ⬆️
sqlite 76.56% <100.00%> (?)
unit 59.85% <0.00%> (+2.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@villebro villebro merged commit 5a3b1ee into apache:master Aug 2, 2024
39 of 41 checks passed
WanjohiWanjohi pushed a commit to IDinsight/surveystream_superset_source that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature global:async-query Related to Async Queries feature size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants