feat: Persian translations #29580
feat: Persian translations #29580
Conversation
|
We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the |
github-actions
bot
added
i18n
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29580 +/- ##
==========================================
+ Coverage 60.48% 70.39% +9.90%
==========================================
Files 1931 1970 +39
Lines 76236 78640 +2404
Branches 8568 8974 +406
==========================================
+ Hits 46114 55360 +9246
+ Misses 28017 21078 -6939
- Partials 2105 2202 +97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
You can install and run the pre-commit hook to fix the linting errors. The SQLite test failure is probably unrelated. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
CodeWithEmad
force-pushed
the
feat/persian-translations
branch
from
456afa3
to
888c154
Compare
|
Fixed. I checked the test env (which is such a cool command!) but haven't seen the flags. in login. maybe I should add it somewhere else? |
|
Oh... turning on the test language file in |
superset/config.py
Outdated
| @@ -370,6 +370,7 @@ def _try_json_readsha(filepath: str, length: int) -> str | None: | |||
| "en": {"flag": "us", "name": "English"}, | |||
| "es": {"flag": "es", "name": "Spanish"}, | |||
| "it": {"flag": "it", "name": "Italian"}, | |||
| "fa": {"flag": "ir", "name": "Persian"}, | |||
There was a problem hiding this comment.
It's good to add this here, but line 389 below disables this whole block. For testing purposes, you can add a few languages there and they should show up on the ephemeral/test environments on this PR.
Sorry I haven't had time to build/test this locally yet... I'm still hoping to.
There was a problem hiding this comment.
Done. You're right, I didn't check other lines.
Don't even mention it. Thanks for helping me out.
CodeWithEmad
force-pushed
the
feat/persian-translations
branch
from
ad65009
to
6bc55cf
Compare
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://34.220.159.126:8080. Credentials are |
|
OMG. I'm so so sorry. It's working fine in the test env. There must be something wrong with my local setup. I'll close the issue, but keep this PR as a draft so I can add translations in the future. |
No description provided.