Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update xss requirement from ^1.0.14 to ^1.0.15 in /superset-frontend/plugins/plugin-chart-table #27835

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Updates the requirements on xss to permit the latest version.

Changelog

Sourced from xss's changelog.

v1.0.15 (2024-03-03)

v1.0.14 (2022-08-16)

v1.0.13 (2022-06-07)

v1.0.12 (2022-06-04)

v1.0.11 (2022-03-06)

v1.0.10 (2021-10-08)

v1.0.9 (2021-05-06)

v1.0.8 (2020-07-27)

v1.0.7 (2020-06-08)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependabot npm Dependabot - npm related PRs labels Apr 1, 2024
@rusackas
Copy link
Member

rusackas commented Apr 2, 2024

@mistercrunch I'm still stumped why the actions don't have permissions to push to the branch. Curious if you have any theories.

Updates the requirements on [xss](https://github.com/leizongmin/js-xss) to permit the latest version.
- [Changelog](https://github.com/leizongmin/js-xss/blob/master/CHANGELOG.md)
- [Commits](leizongmin/js-xss@v1.0.14...v1.0.15)

---
updated-dependencies:
- dependency-name: xss
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@mistercrunch mistercrunch force-pushed the dependabot/npm_and_yarn/superset-frontend/plugins/plugin-chart-table/xss-tw-1.0.15 branch from 422ecc7 to d5bac37 Compare April 2, 2024 22:49
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 2, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@mistercrunch mistercrunch reopened this Apr 2, 2024
@mistercrunch
Copy link
Member

@mistercrunch I'm still stumped why the actions don't have permissions to push to the branch. Curious if you have any theories

Do you mean this? -> looks ok to me.
Screenshot 2024-04-02 at 4 00 13 PM

But in general about permissions to push to the repo you'll need something like
https://github.com/apache/superset/blob/master/.github/workflows/latest-release-tag.yml#L10-L11
and
https://github.com/apache/superset/blob/master/.github/workflows/latest-release-tag.yml#L36-L37

@mistercrunch
Copy link
Member

For the record here I forced rebased the damn thing, not sure what was wrong with it prior to that

@rusackas
Copy link
Member

rusackas commented Apr 2, 2024

It seems for some reason like the action can't push the commit until one of us humanoids commits or force-pushes the thing.

Previously I was pulling the branch, doing npm install and committing a package lock. It's tedious. Not sure if supersetbot would have different or better luck with this task than this action is having.

mistercrunch added a commit that referenced this pull request Apr 3, 2024
Attempting permissions to address this issue
#27835 (comment)
@mistercrunch
Copy link
Member

@rusackas this may help -> #27860

@rusackas rusackas merged commit 59f0057 into master Apr 3, 2024
35 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/superset-frontend/plugins/plugin-chart-table/xss-tw-1.0.15 branch April 3, 2024 03:36
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request Apr 4, 2024
…set-frontend/plugins/plugin-chart-table (apache#27835)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub-Actions[bot] <github-actions[bot]@users.noreply.github.com>
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
…set-frontend/plugins/plugin-chart-table (apache#27835)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub-Actions[bot] <github-actions[bot]@users.noreply.github.com>
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
…set-frontend/plugins/plugin-chart-table (apache#27835)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub-Actions[bot] <github-actions[bot]@users.noreply.github.com>
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
…set-frontend/plugins/plugin-chart-table (apache#27835)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub-Actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants