-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move supersetbot out of repo #27647
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27647 +/- ##
==========================================
+ Coverage 67.38% 69.72% +2.33%
==========================================
Files 1920 1920
Lines 75242 75242
Branches 8423 8423
==========================================
+ Hits 50705 52461 +1756
+ Misses 22476 20720 -1756
Partials 2061 2061
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a214d8d
to
a355b6c
Compare
26aa038
to
ac50a98
Compare
3860d31
to
e22e255
Compare
0334f31
to
23b1c12
Compare
9599ea3
to
ef52a03
Compare
Just curious, is this out of necessity, or just easier to work on it? It might be nice to move it back into Superset/ASF control once the dust settles if it's just to make it easier to get things spun up and tested for a while. |
Yes the main reason is it doesn't require the same level of scrutiny and rigor as the main repo, and it can have it's own CI/release cycles/tests, . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable... perhaps one day it can make a grand homecoming or something. I think the main thing is we need docs on the wiki so we can evangelize its use.
Right, it can always move back here once things settle. |
c0441b6
to
2304001
Compare
This PR
supersetbot
out of here and onto here https://github.com/apache-superset/supersetbot