Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maps): Rename Ukrainian City to Ukrainian format and deccomunization #27415

Closed
wants to merge 2 commits into from

Conversation

0xFillin
Copy link

@0xFillin 0xFillin commented Mar 6, 2024

SUMMARY

The city name is listed as “Kiev,” which is the russian variant. + Rename old city name Dnipropetrovsk to Dnipro

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Rename Kiev to Kyiv

The city name is listed as “Kiev,” which is the russian variant.

Resolutions of UN Conferences on the Standardization of Geographical Names recommend that countries cut back on using exonyms (traditional names) and prioritise national official names in publications, documents, and on maps, and that they use latinization systems adopted and recommended by the UN Group of Experts on Geographical Names (as submitted by the particular country) in transliterating foreign toponyms (from languages not based on the Latin alphabet).

For international use of Ukrainian geographical names, the Ukrainian Romanization system is used, as recommended by Resolution X/9 “Romanization of Ukrainian geographical names” of the X UN Conference on the Standardization of Geographical Names (New York, 2012).

At that Conference, “Toponymic Guidelines for Map and other Editors. Ukraine (for international use)” were also approved, setting out the spelling rules for Ukrainian geographical names and their rendering in Latin, and information about the administrative and territorial division of Ukraine (in Ukrainian and Latin), which is available on the website of the UN Group of Experts on Geographical Names (UNGEGN).

https://unstats.un.org/UNSD/geoinfo/UNGEGN/ungegnConf10.html
…ipro

Rename Kiev to Kyiv and Dnipropetrovsk to Dnipro

The city name is listed as “Kiev,” which is the russian variant.

Resolutions of UN Conferences on the Standardization of Geographical Names recommend that countries cut back on using exonyms (traditional names) and prioritise national official names in publications, documents, and on maps, and that they use latinization systems adopted and recommended by the UN Group of Experts on Geographical Names (as submitted by the particular country) in transliterating foreign toponyms (from languages not based on the Latin alphabet).

For international use of Ukrainian geographical names, the Ukrainian Romanization system is used, as recommended by Resolution X/9 “Romanization of Ukrainian geographical names” of the X UN Conference on the Standardization of Geographical Names (New York, 2012).

At that Conference, “Toponymic Guidelines for Map and other Editors. Ukraine (for international use)” were also approved, setting out the spelling rules for Ukrainian geographical names and their rendering in Latin, and information about the administrative and territorial division of Ukraine (in Ukrainian and Latin), which is available on the website of the UN Group of Experts on Geographical Names (UNGEGN).

https://unstats.un.org/UNSD/geoinfo/UNGEGN/ungegnConf10.html
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@villebro
Copy link
Member

villebro commented Mar 6, 2024

Thanks for the PR @Fillin-Trader. It would be helpful if you can add references in the description to support the proposed changes, as these are likely not obvious to someone without in depth knowledge of the area and how the names are commonly translated to English.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (ce0b70c) to head (93b2047).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27415      +/-   ##
==========================================
+ Coverage   67.34%   69.71%   +2.36%     
==========================================
  Files        1909     1909              
  Lines       74622    74622              
  Branches     8324     8324              
==========================================
+ Hits        50257    52024    +1767     
+ Misses      22312    20545    -1767     
  Partials     2053     2053              
Flag Coverage Δ
hive 53.75% <ø> (?)
javascript 57.20% <ø> (ø)
mysql 77.97% <ø> (ø)
postgres 78.10% <ø> (ø)
presto 53.70% <ø> (?)
python 83.14% <ø> (+4.91%) ⬆️
sqlite 77.61% <ø> (ø)
unit 56.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas changed the title Rename Ukrainian City to Ukrainian format and deccomunization fix(maps): Rename Ukrainian City to Ukrainian format and deccomunization Mar 7, 2024
@rusackas
Copy link
Member

rusackas commented Mar 7, 2024

If we want this change to "stick" we should make an edit in the Jupyter notebook, rather than editing a generated file which might get overridden.

@villebro
Copy link
Member

villebro commented Mar 7, 2024

If we want this change to "stick" we should make an edit in the Jupyter notebook, rather than editing a generated file which might get overridden.

Very good point @rusackas - let's make sure at least the notebook has this update, and even better, requesting the update at the source, rather than as an override in our script.

@rusackas
Copy link
Member

rusackas commented Mar 7, 2024

Ooh, that's even better. If NaturalEarth would reflect this in their data, the fix would be far more impactful than affecting only Superset.

@rusackas
Copy link
Member

rusackas commented Apr 2, 2024

One bit of technical feedback here: This geojson will be overwritten whenever anyone runs the Jupyter Notebook, and pulls new data from Natural Earth. So if you want to make changes to the geojson file, it should be done in the notebook as part of that process/worflow.

To address the elephant in the room: This does indeed feel a little political in nature, which is something we generally try not to dabble in in general. For instance, when there is a boundary dispute, we both sides "win" in the maps. With a given name, we don't usually default to the region's own language for the name; for example, we have a Spain map... not an España map. However, in this case, things are a little different, since indeed Kiev was imposed as a standard the USSR, which clearly no longer exists in its own right. Ukraine has been trying to adjust this standard since its independence in 1991, which far predates the current geopolitical struggles it faces, so I think there's a strong case to change it. Additionally, in 2019, the United States Board on Geographic Names officially changed its official spelling to "Kyiv," so I believe this change has merit if we're going to refer to other regions/territories by their American-English names (e.g. Spain). In other words, while this feels like stepping in controversy, I feel like this is actually consistent, current, accurate, and I'd have a significantly harder time making a case for the opposite.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the Examples dashboard change, even if the geojson is at risk of being overwritten/reverted.

@rusackas
Copy link
Member

Closing this since it's not fixed in the notebook, and at least half of it was covered by this PR: #28226

If you want to rename Dnipropetrovsk to Dnipro (fine with me!) then please open a new PR that updates the Jupyter Notebook, or file an issue so someone else can fix it when they have time.

@rusackas rusackas closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants