Alerts and Reports not working after updating SMTP credentials

[mayanklalwani]

Bug description

I was using the Alerts and Reports feature and it was all working fine. Recently, we changed SMTP credentials (username and password) in the superset_config.py file and after that gettint error :

[2024-06-10 16:32:18,187: DEBUG/ForkPoolWorker-1] Taking a PNG screenshot of url http://superset:8088/explore/?form_data=%7B%22slice_id%22%3A%20535%7D&force=false&standalone=true as user mayank
[2024-06-10 16:32:21,561: DEBUG/ForkPoolWorker-1] [stats_logger] (gauge) reports.email.send.error1
[2024-06-10 16:32:21,561: WARNING/ForkPoolWorker-1] SupersetError(message="(535, b'Authentication Credentials Invalid')", error_type=<SupersetErrorType.REPORT_NOTIFICATION_ERROR: 'REPORT_NOTIFICATION_ERROR'>, level=<ErrorLevel.ERROR: 'error'>, extra=None)
[2024-06-10 16:32:21,579: INFO/ForkPoolWorker-1] Task reports.execute[dbc6f6b4-7e6c-4a1d-a123-46a4b9461e34] succeeded in 21.56079413369298s: None

I have separately tested the new credentials, by a simple python script and the credentials are absolutely correct. What could be the reason for this error in Superset?

How to reproduce the bug

1. Change SMTP_USER and SMTP_PASSWORD.
2. Trigger a report.

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

• I have searched Superset docs and Slack and didn't find a solution to my problem.
• I have searched the GitHub issue tracker and didn't find a similar bug report.
• I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[dosubot[bot]]

Hey @mayanklalwani! I'm here to help you with any bugs, questions, or contributions. Let's tackle this issue together!

The "Authentication Credentials Invalid" error after changing the SMTP credentials in the superset_config.py file, despite the credentials being correct when tested separately, could be due to the EMAIL_NOTIFICATIONS setting being set to False. This setting needs to be True to enable email notifications.

Here is the relevant part of the configuration:

# smtp server configuration
EMAIL_NOTIFICATIONS = False  # all the emails are sent using dryrun
SMTP_HOST = "localhost"
SMTP_STARTTLS = True
SMTP_SSL = False
SMTP_USER = "superset"
SMTP_PORT = 25
SMTP_PASSWORD = "superset"
SMTP_MAIL_FROM = "[email protected]"

To resolve the issue, change EMAIL_NOTIFICATIONS to True:

EMAIL_NOTIFICATIONS = True

This change will enable email notifications and should resolve the "Authentication Credentials Invalid" error if the SMTP credentials are correct ^[1].

To continue talking to Dosu, mention @dosu.

[rusackas]

Sorry for the dumb tech support "is it plugged in?" question, but did you restart Superset after changing the config?

[mayanklalwani]

I did a restart, but that was not working, however, after this comment, I went back and checked all the images being used and it appeared that superset_worker container image had been changed.

Once I changed the image back to my previously working image with new credentials, this feature started working.

Thanks for your help!

[sfirke]

Also these variables can be set in multiple places - a .env file, superset_config.py, config.py, superset_config_docker.py. If the old ones remain in a different file that is getting loaded after where you set them, that could cause this problem.

We can probably convert this to a discussion as it seems more like a config settings issue, not a bug in the Superset codebase.