Replies: 1 comment
-
this is awesome!thank you Agata for point out issues as you move. 🙏 i removed the Polidea label for now as this issue may not land on you guys. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In dual line chart, which according to superset-ui does not have any supported annotation types, it is possible to open modal with adding new annotation. Bar chart does not have any supported annotation types and this section is hidden - it works fine in that case.
In superset-ui
controlPanel
forDualLine
,sections.annotations
should be removed. That way it will be consistent withDualLineChartPlugin
metadata, that Dual Line chart does not have any supported annotation types.It is worth checking if it is consistent for other charts to avoid future bugs.
Expected results
In the left bar, Add Annotation Layer button and the whole annotation section should be hidden.
Actual results
The annotation section is displayed and the modal opens. It is impossible to add any working annotation.
Screenshots
How to reproduce the bug
Environment
Checklist
Make sure to follow these steps before submitting your issue - thank you!
Additional context
Partly connected with PR #11876
Beta Was this translation helpful? Give feedback.
All reactions